Refactor IsoBased.execute_routing() into helper methods #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @kdemmich, I refactored the `IsoBased.execute_routing()` method to improve readability and maintainability. ### What I did - Broke down `execute_routing()` into smaller private helper methods: - `_handle_destination(self, constraints_list)` - `_handle_waypoint(self, constraints_list)` - `_handle_normal_step(self)` - `_finalize_execution(self)` - `_select_best_route(self)` - Main method now acts as an orchestrator - Verified that all existing tests pass (`pytest tests/test_isobased.py -v`) ### Why This structure makes the function easier to read, maintain, and extend. I’m still a beginner, so any feedback or suggestions are welcome 🙂 Thanks!
Collaborator
|
Hi @SadguruSai, thank you for your PR. We appreciate the time and effort that was put into it but, unfortunately, we decided to decline your PR as the features that it implements are already addressed by PR 60. In this context, I would like to take the chance to point you to our updated guidelines for software contributions which require to follow 52 North's CLA guidelines for all future PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @kdemmich,
I refactored the
IsoBased.execute_routing()method to improve readability and maintainability.What I did
execute_routing()into private helper methods:_handle_destination(self, constraints_list)_handle_waypoint(self, constraints_list)_handle_normal_step(self)_finalize_execution(self)_select_best_route(self)_increment_count()– helper to increment relevant counters_decrement_count()– helper to decrement relevant counterspytest tests/test_isobased.py -v)Why
This structure makes the function easier to read, maintain, and extend.
I’m still a beginner, so any feedback or suggestions are welcome 🙂
Thanks!