Bug-fix: Input Validation for RouteParams.from_file #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Description:** This PR adds robust input validation to the `RouteParams.from_file` method in `WeatherRoutingTool/routeparams.py`. Previously, malformed JSON input files could lead to runtime errors when loading route parameters. The updated method now includes comprehensive checks for required fields and their data types, raising descriptive `ValueError` exceptions. This improves the application's stability and prevents crashes from invalid route data. **Files Modified:** * `WeatherRoutingTool/routeparams.py`
Contributor
Author
|
Hey @kdemmich, would you please review this PR? |
Collaborator
|
Hi @pankaj-bind, due to the holiday season, PR reviews might take a bit longer than usual. We apologise and will address your PR as soon as possible. |
Contributor
Author
|
Hey @kdemmich, any update? |
Collaborator
|
Hi @pankaj-bind , thank you for your PR. We appreciate the time and effort that was put into it but, unfortunately, we decided to decline the PR due to its limited added value to the tool. We apologize for the belated review. In this context, I would like to take the chance to point you to our updated guidelines for software contributions which require to follow 52 North's CLA guidlines for all future PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds robust input validation to the
RouteParams.from_filemethod inWeatherRoutingTool/routeparams.py. Previously, malformed JSON input files could lead to runtime errors when loading route parameters. The updated method now includes comprehensive checks for required fields and their data types, raising descriptiveValueErrorexceptions. This improves the application's stability and prevents crashes from invalid route data.Files Modified:
WeatherRoutingTool/routeparams.py