Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Added the option to pass in the branch to use. #145

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

ben51degrees
Copy link
Contributor

@ben51degrees ben51degrees commented Jan 27, 2025

Adds the optional input parameter of 'branch' to the PR workflows.
If the option is not passed, then the default of github.ref_name is used.
This is required in situations where the triggering reference is not one that can be pulled, e.g. a pull request where the id is used as the ref.

@justadreamer justadreamer requested review from pi-alexander-popel and removed request for justadreamer January 27, 2025 17:55
@pi-alexander-popel
Copy link
Collaborator

I remember there being issues with artifact downloads and the test results publishing when I tried to take a similar approach with building the version/4.5 branches. Can't find the details though.

I'd suggest switching the repo that requires this change to uses: 51Degrees/common-ci/.github/workflows/nightly-prs-to-main.yml@feature/branch-option for a couple of days to test that this works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants