Draw Line #3
Open
Draw Line #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ardafruit GFX bitmap functions with example
Updated to use latest SPI library
Add PlatformIO library.json
…ndWrite more robust (#44)
* Add 1-D bitmap array support. * Fix drawing issue due to wrong _setWindow() args.
* Add _spiWrite16 * Use _spiWrite16 in the drawBitmap functions * Use HSPI_WRITE_PIXELS in 1D color drawBitmap * Add _spiWrite16 * 1D drawBitmap should have own description * j iteratoes over h, so it should be j*w not j*h * Only actually need one loop * Add HSPI_WRITE_PIXELS to 2D color drawBitmap * Fix indentation
…de effects. The (#62) operations on the port are non-atomic, and can have unwanted and unexpected side effects on software running on the other CPU core if this software also accesses IO ports. In addition, FAST_PINIO is also not fast on ESP32. My reference board (T-Beam v1.0) takes 2.48s to flip a pin 10e7 times with digitalWrite(pin, ON); digitalWrite(pin, OFF). It takes 2.52s to flip the same pin 10e7 times with *pin |= pinmask; *pin &= ~pinmask. So this modification causes a slight speed-up and removes serios problems.
Cannot compile with unknown SPI_WRITE16
* remove compiler warnings * Remove unused variable Use HSPI_WRITE
I think there is a small type error on line 28 for STM32 boards: uint32 --> uint32_t
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ive tried using drawline and can only get lines in one direction, that is going from top left to bottom right. If I try to get a line in the other direction, that is top right to bottom left the lines are ether horizontal or vertical.