Skip to content

Commit

Permalink
Merge pull request #120 from Charlytoc/master
Browse files Browse the repository at this point in the history
Succesfully finished integration with new compiler and editor
  • Loading branch information
alesanchezr authored Apr 10, 2024
2 parents ebc5359 + 9d18924 commit 2559b8a
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
// Use 'forwardPorts' to make a list of ports inside the container available locally.
// "forwardPorts": [],

"onCreateCommand": "npm i jest@24.8.0 @learnpack/[email protected].26 -g && learnpack plugins:install learnpack-react"
"onCreateCommand": "npm i jest@29.7.0 -g && npm i [email protected] -g && npm i @learnpack/[email protected].47 -g && learnpack plugins:install @learnpack/react@1.1.14"

// Use 'postCreateCommand' to run commands after the container is created.
// "postCreateCommand": "yarn install",
Expand Down
2 changes: 1 addition & 1 deletion .gitpod.dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ FROM gitpod/workspace-full:latest

USER gitpod

RUN npm i jest@24.8.0 @learnpack/[email protected].26 -g && learnpack plugins:install learnpack-react
RUN npm i jest@29.7.0 -g && npm i [email protected] -g && npm i @learnpack/[email protected].47 -g && learnpack plugins:install @learnpack/react@1.1.14
3 changes: 2 additions & 1 deletion exercises/05-adding-styles/tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,12 @@ test("ReactDOM needs to be called once", () => {

test("The component Badge should return the exact HTML", () => {
const tree = renderer.create(ReactDOM.render.mock.calls[0][0]).toJSON();
// throw tree
expect(tree).toMatchInlineSnapshot(`
<button
className="btn btn-primary"
style={
Object {
{
"background": "black",
"border": "1px solid yellow",
"fontSize": "16px",
Expand Down
4 changes: 2 additions & 2 deletions exercises/05.1-second-styles/tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ test("The component Badge should return the exact HTML", () => {
<button
className="btn btn-primary"
style={
Object {
{
"background": "yellow",
"border": "none",
"color": "black",
Expand All @@ -27,7 +27,7 @@ test("The component Badge should return the exact HTML", () => {
<span
className="badge badge-light"
style={
Object {
{
"background": "red",
"borderRadius": "50%",
}
Expand Down
2 changes: 1 addition & 1 deletion learn.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@
"bugsLink": "https://github.com/learnpack/learnpack/issues/new",
"grading": "isolated",
"editor": {
"version": "1.0.73"
"version": "3.1.23"
}
}

0 comments on commit 2559b8a

Please sign in to comment.