Add ability to use FullName, FirstName, LastName, NickName or UserName(if neither is set) as nick for Mattermost #2108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update variables added UseFullName and UseLastName
Added functions for First and Last names
Add ability to use FullName, FirstName, LastName, NickName or UserName(if neither is set) as nick for Mattermost
Added examples NickName/FullName/FirstName/LastName/UserName for Mattermost
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| rmsg.Username = b.mc.GetLastName(rmsg.UserID) | ||
| } | ||
| } else if b.GetBool("UseFullName") { | ||
| if b.mc.GetFirstName(rmsg.UserID) != "" && b.mc.GetLastName(rmsg.UserID) != "" { |
There was a problem hiding this comment.
Avoid deeply nested control flow statements.
|
Code Climate has analyzed commit b502420 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new options to use as nicks for Mattermost