Skip to content
Closed
Show file tree
Hide file tree
Changes from 13 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/my-core-bot-c-Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,5 @@ COPY --from=connection /connection/core_lib.a /core/con_lib.a

# SHELL ["/bin/bash", "-c"]
# ENV SHELL=/bin/bash

CMD ["tail", "-f", "/dev/null"]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to keep the container running

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is not necessary as the devcontainer extension handles that for you...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is still not necessary 😂

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still.....

15 changes: 8 additions & 7 deletions .github/workflows/my-core-bot-ts-Dockerfile
Original file line number Diff line number Diff line change
@@ -1,18 +1,19 @@
ARG TAG_NAME="dev"
ARG SERVER_IMAGE="ghcr.io/42core-team/server"

FROM oven/bun:latest AS bun-base
FROM oven/bun:debian AS bun-base
Comment thread
Peu77 marked this conversation as resolved.
Outdated
WORKDIR /app

FROM ${SERVER_IMAGE}:${TAG_NAME} AS game
RUN apt-get update && \
apt-get install -y make && \
rm -rf /var/lib/apt/lists/*

RUN bun add -g typescript

# Build connection library from monorepo sources
FROM bun-base AS connection
WORKDIR /connection
COPY bots/ts/client_lib/ ./
FROM ${SERVER_IMAGE}:${TAG_NAME} AS game

FROM bun-base AS release

COPY --from=game /core/server /core/server
COPY --from=game /core/data /core/data
COPY --from=connection /connection/ /core/ts/client_lib/
COPY bots/ts/client_lib/ /core/client_lib/
Comment thread
PaulicStudios marked this conversation as resolved.
Outdated
Loading
Loading