Skip to content

Merge release/2.5.0 into master#456

Open
vijaiaeroastro wants to merge 76 commits intomasterfrom
premerge/2.5.0_into_master
Open

Merge release/2.5.0 into master#456
vijaiaeroastro wants to merge 76 commits intomasterfrom
premerge/2.5.0_into_master

Conversation

@vijaiaeroastro
Copy link
Collaborator

Since direct merge from release/2.5.0 into master had too many merge conflicts, I premerged in a branch.

t-paul and others added 30 commits March 15, 2025 21:15
* Bump cmake_minimum_required to 3.5

CMake 4.0 has dropped support for older versions, and fails to build.
GHA's runners have now been (partially) updated to use CMake 4.0, causing the builds to fail.

* Bump cmake from 2.6->3.5 in SDK/Examples/Cpp/CMakeLists.txt
Inclusion of <algorithm> is needed in order to use std::find, but it was
missing, leading to compiler errors with gcc-14 on Debian Trixie.
* Include changes to accomodate spec info for triangle sets, volumetric and implicit. Version numbers are not correctly updated yet. Will do so after confirmation. Tests will fail too.

* Set correct spec version for trianglesets, volumetric and implicit
updating windows version from 2019 to 2022 github actions
…for tests

[CMakeLists.txt] Update OpenSSL linking logic based on USE_INCLUDED_SSL flag
[UnitTest_EncryptionUtils.cpp] Implement cleanup logic for OpenSSL version compatibility
…equired beam lattice ball extensions and add tests for namespace compliance
fixing initialization order

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…t.cpp


fixing initialization order

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ilures and MUSTFAIL passes for latest release and commit
…h helper function to extract zip entry from buffer
gangatp and others added 21 commits December 11, 2025 16:18
…on_2.5.0

updating cpp documentation for 2.5.0 release
* Bump version in CMakeLists.txt

* Switch .sh for .py

* fix artifact caching

* Mac libraries might not obey alpha or beta.

* Update actions to capture artifacts properly

* Fix YAML syntax error

* Yet another attempt at fixing artifact name

* Cache test suite (remove from artifacts)

* Static library support

* Guard shared vs static properly
@vijaiaeroastro vijaiaeroastro marked this pull request as ready for review February 26, 2026 00:28
@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

❌ Patch coverage is 83.58974% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.66%. Comparing base (9ada20e) to head (89cf743).

Files with missing lines Patch % Lines
Autogenerated/Bindings/Cpp/lib3mf_implicit.hpp 83.58% 32 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #456      +/-   ##
==========================================
+ Coverage   59.08%   59.66%   +0.58%     
==========================================
  Files          64       64              
  Lines       23589    24646    +1057     
==========================================
+ Hits        13937    14705     +768     
- Misses       9652     9941     +289     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@@ -0,0 +1,90 @@
# Plan: Extend lib3mf for New Implicit Nodes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should remove this file

</method>

<method name="GetOutputNormalizedGradient" description="Retrieves the normalized gradient output">
<param name="NormalizedGradient" type="class" class="ImplicitPort" pass="return"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hoops, we have a mismatch with the spec. In https://github.com/3MFConsortium/spec_volumetric/blob/master/3MF%20Volumetric%20Extension.md#functiongradient the normalized gradient is just called "vector"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will create a PR to this branch later to fix it

Copy link
Collaborator Author

@vijaiaeroastro vijaiaeroastro Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@3dJan Approved and merged. We need to do the same in develop once PR #454 is merged into develop.

* [FunctionGradientNode] Rename GetOutputNormalizedGradient to GetOutputVector and update related bindings and documentation to reflect the change in output type from normalized gradient to vector

* [FunctionGradientNode] Rename GetOutputNormalizedGradient to GetOutputVector and update related bindings and documentation to reflect the change in output type

* [implicit_nodes_extension_plan.md] Remove the implicit nodes extension plan document as it is no longer needed

* Update Tests/CPP_Bindings/Source/ImplicitNodes.test.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Vijai Kumar S <2363451+vijaiaeroastro@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@vijaiaeroastro vijaiaeroastro requested a review from 3dJan February 28, 2026 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants