cmake/ci: enforce install contract for packagers (fail-fast + smoke test)#451
Open
piotrekoo wants to merge 1 commit into3MFConsortium:developfrom
Open
cmake/ci: enforce install contract for packagers (fail-fast + smoke test)#451piotrekoo wants to merge 1 commit into3MFConsortium:developfrom
piotrekoo wants to merge 1 commit into3MFConsortium:developfrom
Conversation
44fa4b7 to
51867e2
Compare
740df9d to
cbdd3bc
Compare
cbdd3bc to
0c26902
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #450,
This PR hardens the install contract for downstream packagers (e.g. Homebrew) by validating installation end-to-end instead of relying on manual downstream workarounds.
What changed
install(TARGETS lib3mf ...)lib3mf.pclib3mftarget file exists:cmake/VerifyTargetFile.cmakePOST_BUILDin CMake.CI/install_smoke_test.sh-DUSE_INCLUDED_ZLIB=OFF-DUSE_INCLUDED_LIBZIP=OFF-DUSE_INCLUDED_SSL=OFF-DLIB3MF_TESTS=OFFcmake --installlib3mf*.so|dyliblib3mf.pclib3mf.h,lib3mf_types.h)pkg-config --cflags --libs lib3mf#include <lib3mf.h>.install-linux-packagers-smoketo enforce this contract in upstream CI.lib3mf.pctemplate:Libs.private(-lzip -lz)Cflagsto point to the C API headers inBindings/C.Why
Install regressions can reappear if only install rules exist but are not validated after
cmake --install.This PR makes the packager configuration explicitly tested and guaranteed upstream.