Fix macOS bundle executable name #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hello @YuriSizov, Thank you for your contribution 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there!
These names in the bundle plist must match the actual executable name (last changed in #205, I believe), otherwise codesign fails. At least with
rcodesignI get "could not find main executable of presumed nested bundle", which leads to an improperly signed bundle which fails notarization.It is possible that genuine Apple toolchain somehow works around this and finds the executable regardless, I didn't check. Though from my own experience building and signing GDExtension on macOS the contents of plist files is very sensitive, so best it is as correct as possible.