Add features for other tls types #497
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turned out to be rather easy due to all tls being handled by our dependencies. Don't love the _fallback-tls feature, however with it we can use cargo-all-features, which helps reduce feature related bugs. Downside of cargo-all-features is it takes a long time to execute. Fixes: 1c3t3a#407, 1c3t3a#366
There's still an error with ci. engineio/src/lib.rs/test/tls_connector doesn't function the same as native-tls one (as it properly validates hostnames) Needs further investigation as to why the hostname shows as invalid in ci. If we no longer need that, then this PR can be merged.
Turned out to be rather easy due to all tls being handled by our dependencies. Don't love the _fallback-tls feature, however with it we can use cargo-all-features, which helps reduce feature related bugs. Downside of cargo-all-features is it takes a long time to execute. Fixes: 1c3t3a#407, 1c3t3a#366
There's still an error with ci. engineio/src/lib.rs/test/tls_connector doesn't function the same as native-tls one (as it properly validates hostnames) Needs further investigation as to why the hostname shows as invalid in ci. If we no longer need that, then this PR can be merged.
NXD-0: Update webpki due to vulnerabilities
…s-types' into tyler/feat-add-features-for-other-tls-types
tylerhawkes
commented
Apr 22, 2025
| .build() | ||
| .unwrap(), | ||
| ) | ||
| // .tls_config( |
There was a problem hiding this comment.
I can remove this, since it isn't needed for the tests to pass.
| @@ -42,9 +42,9 @@ impl AsyncWebsocketGeneralTransport { | |||
| let mut sender = self.sender.lock().await; | |||
|
|
|||
| sender | |||
| .send(Message::text(Cow::Borrowed(from_utf8(&Bytes::from( | |||
| .send(Message::text(Utf8Bytes::try_from(Bytes::from( | |||
There was a problem hiding this comment.
This and the other changes in this file are due to upgrading tungstenite. This avoids an extra allocation that was happening inside of the text call.
|
|
||
| pub(crate) fn tls_connector() -> error::Result<TlsConnector> { | ||
| pub fn tls_connector() -> error::Result<TlsConfig> { |
There was a problem hiding this comment.
this is exposed to the socketio crate for use in tests.
Comment on lines
+212
to
+215
| #[cfg_attr( | ||
| feature = "_native-tls", | ||
| doc = r#" | ||
| # Example for native-tls |
There was a problem hiding this comment.
These look less appealing, but allows the docs build for all feature configurations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #465 that was originally done by @ctrlaltf24.
My company has been using that branch with a few minor improvements. I just got the tests passing by changing how the certificates and keys are generated so that rustls will accept
localhostin a secure connection.