Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the default 1Password CLI version to 2.23.0 #15

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dustin-ruetz
Copy link
Contributor

@dustin-ruetz dustin-ruetz commented Oct 18, 2023

Update the default version of the 1Password CLI being installed in the orb from 2.7.1 to 2.23.0 (i.e. the latest stable version) so that 1Password service accounts can be used more easily and with less configuration changes (i.e. having to manually configure the .yaml file to use a more recent version).

@dustin-ruetz dustin-ruetz requested a review from edif2008 October 18, 2023 19:59
@dustin-ruetz dustin-ruetz changed the title feat: update the default 1Password CLI version to 2.21.0 Update the default 1Password CLI version to 2.21.0 Oct 18, 2023
@dustin-ruetz dustin-ruetz self-assigned this Oct 18, 2023
@edif2008
Copy link
Member

This is a great quick win to make this orb up-to-date.
Ideally we'd do something similar to what we did for our GitHub Action integrations: automatically fetch the latest version. In this way, we no longer need to regularly update the default version.

@dustin-ruetz
Copy link
Contributor Author

This is a great quick win to make this orb up-to-date. Ideally we'd do something similar to what we did for our GitHub Action integrations: automatically fetch the latest version. In this way, we no longer need to regularly update the default version.

Thanks for the approval and good callout - I wasn't sure if/how we would go about automatically fetching the latest CLI version in the install-cli.yml file, so I went with the quick win of just updating the version number instead. But yes, definitely something that we could look to revisit in the future 👍

@edif2008 edif2008 changed the title Update the default 1Password CLI version to 2.21.0 Update the default 1Password CLI version to 2.22.0 Nov 13, 2023
@dustin-ruetz dustin-ruetz changed the title Update the default 1Password CLI version to 2.22.0 Update the default 1Password CLI version to 2.23.0 Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants