-
-
Notifications
You must be signed in to change notification settings - Fork 17
Add aria-current option #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it easier to add more attributes when building the A tag while making the markup string interpolation simpler.
Contributor
Author
|
@zachleat Is there anything required for this PR to be merged? I'll raise a PR on the docs site once this one is accepted. Thanks. |
|
+1 for this! 🙂 |
|
@Dexus I don't have write access to this repository. Sorry. |
Contributor
Author
|
@zachleat is there anyone who could review the PR even if they can't merge it? It might help move things along. Thanks. |
Member
|
Shipping with Navigation v1.0.0 — thank you!! |
Contributor
Author
|
Docs MR raised 11ty/11ty-website#1779 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14
It adds a
useAriaCurrentAttroption so that an anchor matching theactiveKeywill have anaria-current="page"attribute (see more details here).Example Nunjucks navigation rendering:
The PR also includes a refactor to make adding tag attributes a bit simpler.