Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump octokit from 1.7.2 to 3.1.2 #28

Merged
merged 4 commits into from
Apr 2, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 18, 2023

Bumps octokit from 1.7.2 to 3.1.2.

Release notes

Sourced from octokit's releases.

v3.1.2

3.1.2 (2023-11-15)

Bug Fixes

  • updates app.js for the handling of an error being thrown by the verify method in webhooks.js (#2576) (b59da80)

v3.1.1

3.1.1 (2023-09-25)

Bug Fixes

v3.1.0

3.1.0 (2023-07-26)

Features

v3.0.0

3.0.0 (2023-07-11)

Features

BREAKING CHANGES

  • Drop support for NodeJS v14, v16
  • Remove previews support for the REST API
  • remove agent option from octokit.request()
  • Replace support for Node.js http(s) Agents with documentation on using fetch dispatchers instead (via @octokit/request)
  • Remove ability to pass custom request options, except for method, headers, body, signal (via @​octokit/request)

v3.0.0-beta.5

3.0.0-beta.5 (2023-07-11)

Bug Fixes

v3.0.0-beta.4

... (truncated)

Commits
  • b59da80 fix: updates app.js for the handling of an error being thrown by the verify m...
  • f514e4b build(deps): lock file maintenance (#2574)
  • fdc9bba chore(deps): update dependency prettier to v3.1.0
  • d3a9984 build(deps): lock file maintenance
  • 870d89d build(deps): lock file maintenance (#2565)
  • 78735dd build(deps): lock file maintenance (#2562)
  • 72ea679 chore(deps): update dependency @​types/node to v20
  • 692f7db ci(action): update actions/setup-node action to v4 (#2560)
  • 5b47b84 build(deps): lock file maintenance (#2558)
  • 941c584 docs: fixing typos in README (#2557)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added the type:dependency An issue with a separate library that this project relies upon (aka a dependency). label Dec 18, 2023
@jeffpaul jeffpaul requested review from a team and ravinderk and removed request for a team December 18, 2023 21:32
@jeffpaul jeffpaul added this to the 0.2.0 milestone Dec 18, 2023
@ravinderk
Copy link

@jeffpaul, Octokit has dropped support for Node v14 and v16. Considering that many open-source repositories are using these Node versions, I suggest updating the package to v2.1.0 to prevent any potential breaking changes and close this pull request.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/octokit-3.1.2 branch from d8dd362 to e4104fa Compare December 22, 2023 12:21
Bumps [octokit](https://github.com/octokit/octokit.js) from 1.7.2 to 3.1.2.
- [Release notes](https://github.com/octokit/octokit.js/releases)
- [Commits](octokit/octokit.js@v1.7.2...v3.1.2)

---
updated-dependencies:
- dependency-name: octokit
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/octokit-3.1.2 branch from e4104fa to c0fbd7b Compare December 22, 2023 12:23
@jeffpaul
Copy link
Member

@ravinderk sounds good, will leave this for anyone on @10up/open-source-practice that wants to pick up that change

@jeffpaul jeffpaul requested review from a team and Sidsector9 and removed request for ravinderk and a team January 16, 2024 21:02
@@ -23,7 +23,7 @@
"dependencies": {
"execa": "^6.1.0",
"meow": "^10.1.2",
"octokit": "^1.7.2"
"octokit": "^3.1.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm audit reports 2 high vulnerability, 1 of which is for octokit < 3.1.2 and 3.1.2 has support for node 18 and 20 only.

Screenshot 2024-01-22 at 11 26 37 AM

I just checked that Gutenberg's development environment is set to node v20. Should we start discussing around the topic of updating node version across our repo to v18 at least?

cc: @10up/open-source-practice

@Sidsector9 Sidsector9 merged commit 49e778b into trunk Apr 2, 2024
4 checks passed
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/octokit-3.1.2 branch April 2, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:dependency An issue with a separate library that this project relies upon (aka a dependency).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants