-
Notifications
You must be signed in to change notification settings - Fork 57
Ajouter un endpoint pour enregistrer les évènements des passages (PIX-16954) #12036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pix-service-auto-merge
merged 4 commits into
dev
from
PIX-16954-add-passage-events-endpoint
Apr 14, 2025
Merged
Ajouter un endpoint pour enregistrer les évènements des passages (PIX-16954) #12036
pix-service-auto-merge
merged 4 commits into
dev
from
PIX-16954-add-passage-events-endpoint
Apr 14, 2025
+357
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
570380d
to
be817bf
Compare
er-lim
reviewed
Apr 14, 2025
api/src/devcomp/application/passage-events/passage-events-controller.js
Outdated
Show resolved
Hide resolved
api/tests/devcomp/acceptance/application/passages/passage-events-controller_test.js
Show resolved
Hide resolved
be817bf
to
86730fe
Compare
yannbertrand
approved these changes
Apr 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alright 🚀
7dca715
to
c7e2170
Compare
c7e2170
to
0565040
Compare
Co-authored-by: Eric Lim <[email protected]> Co-authored-by: Diane Cordier <[email protected]>
Co-authored-by: Eric Lim <[email protected]>
Co-authored-by: Eric Lim <[email protected]>
Co-authored-by: Eric Lim <[email protected]>
0565040
to
7c5f234
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution
On souhaite enregistrer des évènements lors d'action d'utilisateurs qui ne sont pas liés à des appels à l'API. Nous avons donc besoin d'une route dédiée que le front puisse appeler pour demander l'enregistrement de tels évènements.
🌳 Proposition
Ajouter ce endpoint.
🐝 Remarques
Bien qu'on l'enverra qu'un seul évènement à la fois dans un premier temps, nous souhaitons que le front ait la capacité d'envoyer un lot d'évènements en une seule requête pour des raisons de performance. L'API s'attend donc à recevoir non pas une ressource
PassageEvent
mais une ressourcePassageEventCollection
dont la propriétépassageEvents
contient un tableau de ressourcesPassageEvent
.🤧 Pour tester
On testera quand on aura le front…