[FEATURE] Créer l'API interne pour mettre à disposition les données des participations par campagne (PIX-17351) #12014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
alicegoarnisson
force-pushed
the
pix-17351-update-campaigns-api-to-get-details-by-subject
branch
from
9e43a1c to
45f0e09
Compare
alicegoarnisson
force-pushed
the
pix-17351-update-campaigns-api-to-get-details-by-subject
branch
2 times, most recently
from
e8a1114 to
5e01670
Compare
Alexandre-Monney
changed the title
alicegoarnisson
force-pushed
the
pix-17351-update-campaigns-api-to-get-details-by-subject
branch
2 times, most recently
from
3919224 to
d7d3336
Compare
api/src/prescription/campaign/domain/usecases/find-paginated-filtered-organization-campaigns.js
Outdated
Show resolved
Hide resolved
alicegoarnisson
commented
Apr 10, 2025
api/tests/prescription/campaign/unit/application/api/campaigns-api_test.js
Show resolved
Hide resolved
alicegoarnisson
force-pushed
the
pix-17351-update-campaigns-api-to-get-details-by-subject
branch
from
d7d3336 to
bead9b0
Compare
VincentHardouin
approved these changes
Apr 10, 2025
alicegoarnisson
force-pushed
the
pix-17351-update-campaigns-api-to-get-details-by-subject
branch
2 times, most recently
from
4d41052 to
86224f4
Compare
machestla
reviewed
Apr 14, 2025
| expect(campaignsWithReports[0]).to.deep.include( | ||
| _.pick(campaign, [ | ||
| expect(campaignsWithReports[0]).to.deep.include({ | ||
| ..._.pick(campaign, [ |
There was a problem hiding this comment.
thought: je trouve cette rédaction un peu difficile à lire
machestla
approved these changes
Apr 14, 2025
xav-car
force-pushed
the
pix-17351-update-campaigns-api-to-get-details-by-subject
branch
from
3f9f3ef to
b4079bd
Compare
alicegoarnisson
force-pushed
the
pix-17351-update-campaigns-api-to-get-details-by-subject
branch
from
07fa0da to
8f836e0
Compare
alicegoarnisson
added
the
👀 Func Review Needed
xav-car
force-pushed
the
pix-17351-update-campaigns-api-to-get-details-by-subject
branch
from
8f836e0 to
e363fa5
Compare
HEYGUL
approved these changes
Apr 14, 2025
HEYGUL
reviewed
Apr 15, 2025
Comment on lines
550
to
551
| expect(campaignsWithReports[0]).to.deep.include({ | ||
| ..._.pick(campaign, [ |
There was a problem hiding this comment.
Le spread n'est pas nécessaire
Suggested change
| expect(campaignsWithReports[0]).to.deep.include({ | |
| ..._.pick(campaign, [ | |
| expect(campaignsWithReports[0]).to.deep.include( | |
| _.pick(campaign, [ |
machestla
added
Tech Review OK
and removed
👀 Func Review Needed
lionelB
approved these changes
Apr 15, 2025
lionelB
approved these changes
Apr 15, 2025
alicegoarnisson
force-pushed
the
pix-17351-update-campaigns-api-to-get-details-by-subject
branch
from
c76af31 to
78a5b89
Compare
Co-Authored-By: alicegoarnisson <[email protected]>
Co-Authored-By: alicegoarnisson <[email protected]> Co-Authored-By: Yvonnick FRIN <[email protected]>
…etences models in tests into domainBuilder
…OrganizationCampaigns
pix-service-auto-merge
force-pushed
the
pix-17351-update-campaigns-api-to-get-details-by-subject
branch
from
78a5b89 to
28a32f8
Compare
pix-service-auto-merge
deleted the
pix-17351-update-campaigns-api-to-get-details-by-subject
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌸 Problème
Les données concernant les participations à une campagne doivent être mises à disposition aux partenaires qui le demandent.
🌳 Proposition
On enrichit une méthode existante sur CampaignsApi pour créer une API interne à l'usage de Team-Maddo.
🐝 Remarques
🤧 Pour tester