Added rank (plus minor fixes) #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't really think anyone was still using this. Thanks for the PR. Are you in the GD Programming Discord? I can send an invite if you aren't. Most community efforts related to hacking/programming for GD is there. |
101arrowz
reviewed
Jan 10, 2021
| /** The player's stats */ | ||
| stats: { | ||
| /** The number of stars the player has collected */ | ||
| stars: number; | ||
| /** The number of demons the player has beaten */ | ||
| demons: number; | ||
| /** The number of diamonds the player has collected */ | ||
| diamonds: number; |
There was a problem hiding this comment.
One thing: this isn't assigned anywhere, are you sure this works?
|
i'm in it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we don't have a rank property. Pretty self-explanatory. It's in the User class.