Check for balance before auto-selecting token options for purhcase

[VGabriel45]

No description provided.

[cloudflare-workers-and-pages]

Deploying web-sdk-react-example with    Cloudflare Pages

Latest commit:	d65e8f6
Status:	✅  Deploy successful!
Preview URL:	https://d0f008f1.web-sdk-react-example.pages.dev
Branch Preview URL:	https://fix-checkout-button-enabled.web-sdk-react-example.pages.dev

View logs

[SamueleA]

Two comments:

1. The console.logs should be cleaned up prior to merging.

2. I see from the title of the PR that there seems to be a problem with the state of the button. I'm assuming it's getting stuck in a particular state such as disabled?

That being said, the code being deleted shouldn't be deleted outright. It's meant to autoselect the first available option—either the main currency or a swap option—which was a QOL feature that was requested in the past. We should keep that functionality in.

I would say we need to go deeper on the bug we are trying to fix here. I lack details personally. Is it possible to have more details?

Just intuitively though… I know that recently the swap API has been changed and that, at least temporarily, it can return options for which the user doesn't have any funds. This wasn't the case before, and it's likely causing an unexpected side effect with this logic.

The deleted code in the PR seems to assume that the user always has enough funds when autoselecting the swap option (because it's not making any balance checks, unlike the main currency), but that's not true anymore. I can imagine the code auto-selecting a swap option for which the user does not have enough funds, which I believe would make the buy button stuck in a disabled state…

To recap, we shouldn't delete this code (though we could improve it—it looks so bad 😆), we should dig deeper into the bug which prompted this PR and keep in mind my hypothesis outlined above, since I think that might be the issue. Also, with hindsight, a line or two of comments for what the code is doing would have been helpful.

[VGabriel45]

Two comments:

1. The console.logs should be cleaned up prior to merging.
2. I see from the title of the PR that there seems to be a problem with the state of the button. I'm assuming it's getting stuck in a particular state such as disabled?

That being said, the code being deleted shouldn't be deleted outright. It's meant to autoselect the first available option—either the main currency or a swap option—which was a QOL feature that was requested in the past. We should keep that functionality in.

I would say we need to go deeper on the bug we are trying to fix here. I lack details personally. Is it possible to have more details?

Just intuitively though… I know that recently the swap API has been changed and that, at least temporarily, it can return options for which the user doesn't have any funds. This wasn't the case before, and it's likely causing an unexpected side effect with this logic.

The deleted code in the PR seems to assume that the user always has enough funds when autoselecting the swap option (because it's not making any balance checks, unlike the main currency), but that's not true anymore. I can imagine the code auto-selecting a swap option for which the user does not have enough funds, which I believe would make the buy button stuck in a disabled state…

To recap, we shouldn't delete this code (though we could improve it—it looks so bad 😆), we should dig deeper into the bug which prompted this PR and keep in mind my hypothesis outlined above, since I think that might be the issue. Also, with hindsight, a line or two of comments for what the code is doing would have been helpful.

Thanks for the review @SamueleA. I'll look into this again, I think it was a quick fix for an issue we had which might not exist now because of some other fixes we did, I'll check and get back on this.