Skip to content

Conversation

@Agusx1211
Copy link
Member

Removes:

        // Validate permitAmount exactly matches the total required amount (deposit + fee)
        // This prevents permit/approval mismatches that could cause DoS or unexpected behavior
        unchecked {
            if (permitAmount != amount + feeAmount) revert PermitAmountMismatch();
        }

introduced on #62, the constraint is not necessary and stops permits from being re-used, forcing 2-click user interactions.


Update the README, remove mentions to non-existent functionality and update intent and function definitions.

@Agusx1211 Agusx1211 requested review from a team and ScreamingHawk November 30, 2025 05:59
Copy link
Contributor

@ScreamingHawk ScreamingHawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Confirmed an excessive approval remains but is safe. All public functions on the entrypoint require the intent signature. Intent signature signers are only able to access their own pre-approvals.

@pkieltyka pkieltyka merged commit 5e45686 into master Nov 30, 2025
1 check passed
@pkieltyka pkieltyka deleted the remove-redundant-check branch November 30, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants