Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ini v3 core #210

Open
wants to merge 224 commits into
base: master
Choose a base branch
from
Open

feat: ini v3 core #210

wants to merge 224 commits into from

Conversation

shunkakinoki
Copy link

@shunkakinoki shunkakinoki commented Feb 20, 2025 •
edited
Loading

Includes all required core configuration, imageHash, signature modules derived from sequence-core for v3 and ensures that all critical tests are passing.

Steps to test

  1. Run the following command from the root go repository to initiate the rpc:
go run ./cmd/sequence/ server
  1. In the v3 module, run the following foundry tests:
forge test --mp test/modules/BaseSig.t.sol

forge test --mp test/modules/Calls.t.sol

forge test --mp test/modules/Payload.t.sol

forge test --mp test/Guest.t.sol

forge test --mp test/Stage1Module.t.sol

forge test --mp test/Wallet.t.sol

Caveats

Some gas-estimation commands, etc. are commented out because of the scope of this PR. will follow up in a later PR. Also, Permission, SmartSession, SessionManager related modules will follow up later.

@shunkakinoki shunkakinoki changed the base branch from master to waas-scoped-sessions February 25, 2025 11:44
@shunkakinoki shunkakinoki changed the base branch from waas-scoped-sessions to master February 25, 2025 11:45
shunkakinoki and others added 30 commits March 26, 2025 18:02
@shunkakinoki
Refactor session permissions and permission parsing to return errors …
ec3f3c3 
…instead of panicking. Update related functions to handle missing or invalid fields gracefully.
@shunkakinoki
Refactor TestTransactionToGuestModuleDeployAndCall to compute metaTxn…
0f84035 
…ID from payload
@attente
fix warnings
d523c31
@attente
rename
e5a1572
@attente
fix filename
f2682ea
@attente
go mod tidy
9b50d5d
@attente
core/v3: v3 -> v3_test
9b68392
@attente
core: TestDigestPayloadMatchesMessagePayload
fdaafd2
@shunkakinoki
Enhance DecodeExecdata to support V3 execute and selfExecute methods,…
682d8fd 
… including payload decoding and transaction conversion. Add recursive decoding for nested transactions.
@shunkakinoki
Merge remote-tracking branch 'refs/remotes/origin/v3-core' into v3-core
ad0bf4c
@attente
manually compute digest payload eip-712 digest
58ba47c
@shunkakinoki
Refactor TryDecodeCalldata to include wallet address and chain ID in …
21c34ae 
…DecodeExecdata calls.
@shunkakinoki
Remove unused import and enhance TestTxnDecodeExecdata txn.
1cf0cd1
@attente
DecodeExecdata: also decode guest module calls
e5e2959
@shunkakinoki @pkieltyka
feat: ini intent config (#202)
04cf2d6 
* feat: ini intent config

* chore: ini stx

* chore: ini two txs

* feat: refactor intent configuration and add signature creation functionality

* feat: ini config v2

* chore: revert v2 internal exposed methods

* chore: update

* feat: ini txn bundle

* feat: update intent configuration to support transaction batches

* feat: ini erc20 configuration transfer

* chore: udpate

* chore: udpate

* v3, init

* move wallet v1 contracts/gen to v1 folder

* update

* Makefile

* TODO

* chore: update

* feat: ini v3

* feat: ini complete migration

* update

* feat: ini signer configurations

* chore: update

* feat: ini v3 artifacts

* feat: ini cli + migration

* feat: udpate

* feat: ini address cmd

* feat: ini config new

* chore: update

* chore: update

* chore: update

* chore: update json encoding

* feat: ini config image hash

* feat: ini cmd

* v3, init

* move wallet v1 contracts/gen to v1 folder

* update

* Makefile

* TODO

* chore: update

* feat: ini v3

* feat: ini complete migration

* update

* feat: ini signer configurations

* chore: update

* feat: ini v3 artifacts

* feat: ini cli + migration

* feat: udpate

* feat: ini address cmd

* feat: ini config new

* chore: update

* chore: update

* chore: update

* chore: update json encoding

* feat: ini config image hash

* feat: ini cmd

* chore: update

* feat: ini v3 signature

* feat: ini method

* feat: ini sessions

* feat: ini config

* chore: wip

* chore: update sig

* chore: update

* feat: improve wallet config tree decoding with explicit type handling

* chore: update

* chore: update

* feat: ini recover random config unsigned

* feat: ini json config

* feat: ini recursive format sig

* feat: ini 1271 sig

* feat: ini sapient

* chore: ini recursive

* chore: ini update

* feat: ini v3

* chore: ini buildkite

* chore: finish update

* chore: finish update finish

* feat: ini working v3

* feat: v3 test pass

* chore: empty

* chore: ini session contracts

* chore: update

* feat: ini deploy fix

* chore: update

* chore: update

* chore: update

* fix: adjust gas limit for stage1 module deployment in V3DeploySequenceContext

* chore: update

* chore: update

* chore: update

* chore: update

* chore: update

* chore: ini test updates

* chore: update test

* chore: update

* chore: mine for next block

* chore: pass for v3

* chore: bypass

* chore: update

* chore: update

* chore: update

* chore: update

* chore: update

* chore: update

* feat: ini intent config

* chore: ini stx

* chore: ini two txs

* feat: refactor intent configuration and add signature creation functionality

* feat: ini config v2

* chore: revert v2 internal exposed methods

* chore: update

* feat: ini txn bundle

* feat: update intent configuration to support transaction batches

* feat: ini erc20 configuration transfer

* chore: udpate

* chore: udpate

* test: add signature type debugging in decode signature test

* chore: ini v3 intent config

* feat: ini testchain mock erc20

* chore: update fix wallet tests

* feat: ini intent config migration

* chore: update

* chore: update

* chore: update

* chore: fix test configuration signature

* chore: update testing

* chore: update

* v3: enhance transaction signing process w/ payload hash

* v3: refactor intent configuration to use DecodedPayload for transaction handling

* v3: update chain ID handling in tests and refactor HashPayload to manual impl

* v3: fix `GetSignedIntentPayload` payload hash

* v2: remove redundant type checks in signature decoding test

* v3: update contracts and add related tests for consistency

* v3: update wallet context addresses for MainModule, GuestModule, and Utils

* v3: refactor GetIntentConfigurationSignature to support noChainID flag

* Update Go modules and deps

* v3: update HashPayload to handle NoChainId flag for effective chain ID

* v3: update CreateIntentBundle and related functions to support noChainId flag for improved chain ID handling

* v3: update TestV3IntentConfigWalletDeployment to use mockBundles for payload hashing

* Comment out the v3 test case in estimator_test.go to prevent execution during testing.

* feat: ini v3 refactor

* refactor: update intent configuration and payload handling

* refactor: replace CallsPayload with IntentOperation struct for constructing intent configurations

* refactor: rename intent related functions and update related tests

* test: add tests for `CreateIntentTree`

* test: implement v3 wallet deployment and transaction estimation tests

* chore: update

* feat: ini intent config core working!!!

* refactor: comment out debug output in intent configuration tests

* chore: sync to v3-core

* refactor: remove debug print statements from payload functions

* Update payload construction to use NewCallsPayload in intent configuration and tests; remove deprecated ConstructCallsPayload references.

* Remove logging statements from intent configuration and wallet files to clean up the codebase.

---------

Co-authored-by: Peter Kieltyka <[email protected]>
@attente
skip data size
8b99fae
@attente
use only first 20 bytes for address
0a84034
@attente
fix TestTxnDecodeExecdata
d8eba1c
@attente
go fmt ./...
4f2ada4
@attente
DecodeExecdata: fix
be3ca86
@attente
catch CallSkipped
ca42f2c
@attente
fail on trailing bytes in call payload
91dd23a
@attente
SignedTransactions.Payload
6d171ff
@attente
SignedTransactions.ExecuteV3
cb92a9c
@attente
graceful fail if cannot unpack revert
bedffeb
@attente
sequence-v3@5d79c64 artifacts
53b2de0
@attente
update context
b49a2e9
@attente
fix test
c57ad4f
@shunkakinoki
Implement minimum gas limit for transaction estimates
51e6181
@shunkakinoki
feat: refactor gas estimate call (#244)
8337909 
* feat: refactor v2 estimate

* refactor: update V2 execution logic and adjust gas limit handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkieltyka pkieltyka Awaiting requested review from pkieltyka

@attente attente Awaiting requested review from attente

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shunkakinoki @pkieltyka @attente @ScreamingHawk