initial ethwal filter index #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marino39
requested changes
Sep 9, 2024
filter_reader.go
Outdated
| } | ||
|
|
||
| func (c *chainLensReader[T]) Seek(ctx context.Context, blockNum uint64) error { | ||
| // TODO: how should seek function? |
There was a problem hiding this comment.
Please implement it as defined here: https://pkg.go.dev/sort#Search
| @@ -6,6 +6,8 @@ type FS storage.FS | |||
|
|
|||
There was a problem hiding this comment.
We may need in-mem cache for fs. Please see if it's available. If nor maybe we need to implement to update indexes efficiently.
filter_index.go
Outdated
| return bmap, nil | ||
| } | ||
|
|
||
| func (i *index[T]) Store(ctx context.Context, block Block[T]) error { |
There was a problem hiding this comment.
This will be highly in-effcient, too much IO. Please consider using IndexBuilder that will collect all of the changes and flush them less frequently.
Shubhaankar-Sharma
force-pushed
the
ethwal-filter
branch
from
c316494 to
2c9d4fe
Compare
Shubhaankar-Sharma
force-pushed
the
ethwal-filter
branch
from
c88651f to
63cbb03
Compare
Ethwal filter improvements
marino39
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.