Skip to content

Merge networks.yaml when using rpc-url #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ScreamingHawk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Merge networks.yaml when using rpc-url #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/commands/run.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,15 +76,19 @@ export function makeRunCommand(): Command {
// Detect network information from RPC URL
const detectedNetwork = await detectNetworkFromRpc(options.rpcUrl)

// Create a complete network object
// Try to find a matching network in networks.yaml by chainId to merge verification platform support
const knownNetwork = networks.find(n => n.chainId === detectedNetwork.chainId)

// Create a complete network object, merging with known network config if found
const customNetwork: Network = {
name: detectedNetwork.name || `custom-${detectedNetwork.chainId}`,
name: detectedNetwork.name || knownNetwork?.name || `custom-${detectedNetwork.chainId}`,
chainId: detectedNetwork.chainId!,
rpcUrl: options.rpcUrl,
// Optional fields with defaults
supports: detectedNetwork.supports || [],
gasLimit: detectedNetwork.gasLimit,
testnet: detectedNetwork.testnet
supports: detectedNetwork.supports || knownNetwork?.supports || [],
gasLimit: detectedNetwork.gasLimit || knownNetwork?.gasLimit,
testnet: detectedNetwork.testnet !== undefined ? detectedNetwork.testnet : knownNetwork?.testnet,
evmVersion: detectedNetwork.evmVersion || knownNetwork?.evmVersion
}

// Custom network created from RPC detection
Expand Down