Skip to content

feat: add HeaderSessionType constant and set it in Session middleware #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
klaidliadon merged 2 commits into from
Dec 4, 2025
Merged

feat: add HeaderSessionType constant and set it in Session middleware #54

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90557ed
feat: add HeaderSessionType constant and set it in Session middleware
klaidliadon Dec 4, 2025
c69065b
fix: propagate HTTP request context in UserStore GetUser call
klaidliadon Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ import (
)

const (
HeaderAccessKey = "X-Access-Key"
HeaderAccessKey = "X-Access-Key"
HeaderSessionType = "Session-Type"
)

type AccessKeyFunc func(*http.Request) string
Expand Down
3 changes: 2 additions & 1 deletion middleware.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,9 +146,9 @@ func Session(cfg Options) func(next http.Handler) http.Handler {
if _, ok := GetSessionType(ctx); ok {
// Track this as a SpecialKey session for now.
// TODO: Remove once node-gateway SpecialKey support is gone.
w.Header().Set(HeaderSessionType, "SpecialKey")
httplog.SetAttrs(ctx, slog.String("sessionType", "SpecialKey"))
requestsCounter.Inc(sessionLabels{SessionType: "SpecialKey", RateLimited: "false"})

next.ServeHTTP(w, r)
return
}
Expand Down Expand Up @@ -260,6 +260,7 @@ func Session(cfg Options) func(next http.Handler) http.Handler {
}

ctx = WithSessionType(ctx, sessionType)
w.Header().Set(HeaderSessionType, sessionType.String())
httplog.SetAttrs(ctx, slog.String("sessionType", sessionType.String()))

ww, ok := w.(middleware.WrapResponseWriter)
Expand Down