Skip to content

Harden local-first install and isolated test paths#109

Draft
SteveSpivak wants to merge 1 commit into0xNyk:mainfrom
SteveSpivak:codex/lacp-local-pilot-fixes
Draft

Harden local-first install and isolated test paths#109
SteveSpivak wants to merge 1 commit into0xNyk:mainfrom
SteveSpivak:codex/lacp-local-pilot-fixes

Conversation

@SteveSpivak
Copy link
Copy Markdown

Summary

This hardening branch fixes the local-first pilot issues discovered while testing LACP on macOS:

  • make bin/lacp test --quick --isolated actually isolate derived roots and avoid default install side effects
  • propagate auto-deps flags from lacp-install into lacp-onboard
  • harden lacp-doctor --json against multiline output corruption
  • normalize common macOS PATH entries and safely expand $LACP_ROOT from the shipped .env example
  • restore lacp-console compatibility with macOS Bash 3.2
  • fix the hardened-session composite profile path in lacp-claude-hooks
  • keep lacp-harness-run --help usable when PyYAML is missing
  • replace the nonexistent swarm doctor bootstrap probe and align docs/tests with the real CLI

Validation

Ran locally on macOS:

  • HOMEBREW_NO_AUTO_UPDATE=1 bin/lacp test --quick --isolated
  • scripts/ci/test-cli-and-isolated-env-guard.sh
  • scripts/ci/test-console.sh
  • bounded worktree / swarm / brain-ingest pilot checks
  • live wrapper smokes for claude and codex through LACP-managed wrappers

Notes

This started as a local adoption pilot, so the branch is intentionally small and safety-focused rather than feature-expanding.

@0xNyk
Copy link
Copy Markdown
Owner

0xNyk commented Apr 13, 2026

Deep triage pass results for #109:

What I validated locally

  • scripts/ci/test-cli-and-isolated-env-guard.sh
  • scripts/ci/test-console.sh
  • HOMEBREW_NO_AUTO_UPDATE=1 bin/lacp test --quick --isolated ✅ (with a local obsidian stub in PATH to avoid host-specific CLI hang in lacp-doctor)
  • bin/lacp-harness-run --help
  • bash -n syntax checks across all changed shell scripts ✅

Security/injection audit

  • No hidden zero-width/control-char instruction payloads found in changed files.
  • No new command-injection patterns detected in this diff.

Blocking issue before merge

  1. bin/lacp-test has an invalid isolated env export path:
    • line sets LACP_MCP_AUTH_POLICY_FILE="${ROOT...json"
    • this should be a concrete config path (likely ${ROOT}/config/mcp-auth-policy.json).

Non-blocking repo state notes

  • PR is still draft.
  • No GitHub checks are currently reported for this branch.

Recommendation

  • Fix the LACP_MCP_AUTH_POLICY_FILE path in bin/lacp-test, re-run the quick isolated suite, then mark ready for review.

@0xNyk
Copy link
Copy Markdown
Owner

0xNyk commented Apr 13, 2026

Correction to my prior blocker note:

I re-verified bin/lacp-test at byte level and confirmed the line is valid in this branch:

export LACP_MCP_AUTH_POLICY_FILE="${ROOT}/config/mcp-auth-policy.json"

My earlier report was caused by output truncation/rendering in one inspection path, not an actual file defect.

Updated triage status:

  • functional checks I ran remain green (test-cli-and-isolated-env-guard, test-console, quick isolated suite)
  • no hidden-instruction/control-char findings in changed files
  • no blocking code issue from that env var line

Remaining merge gates are process-level:

  • PR is still Draft
  • no branch checks currently reported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants