Open
Conversation
onurinanc
reviewed
Feb 13, 2026
9be0d29 to
55282e1
Compare
Replace the single StorageMap-based MetadataExtension with plain value slots for name (2 Words) and content URI (6 Words). - Define 8 value slot names (name_chunk_0..1, content_uri_0..5) - Update MetadataExtension struct to use [Word; 2] and [Word; 6] - Replace MASM `get` proc with `get_name` + `get_content_uri_0..5` - Use @Locals with loc_storew_be/loc_loadw_be to maintain call-frame stack depth of 16 - Update BasicFungibleFaucet and NetworkFungibleFaucet accordingly - Rewrite integration tests for new value-slot access patterns
…undant Info component
…utable_owner_succeeds test
55282e1 to
b1dba96
Compare
onurinanc
reviewed
Feb 15, 2026
| account_storage_mode: AccountStorageMode, | ||
| auth_scheme: AuthScheme, | ||
| name: Option<TokenName>, | ||
| logo_uri: Option<TokenLogoURI>, |
Contributor
There was a problem hiding this comment.
Why do we have both logo_uri & content_uri? we can rename it later for NFTs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unified metadata: One place for account/faucet metadata: token (symbol, decimals, max_supply), owner, name, and content URI. Slot names live under miden::standards::metadata::* (and ownable for owner).
Layout: Token metadata and owner in slots 0–1; name in 2 words (name_0, name_1); content URI in 6 words (content_uri_0..5). Same layout in Rust and MASM.
Faucets: Basic and network fungible faucets support optional name and content URI; both re-export metadata getters (get_name, get_content_uri, get_token_metadata, get_max_supply, get_decimals, get_token_symbol; network also get_owner).
Standalone Info: Non-faucet accounts can use the metadata Info component (name + content URI) for future use (e.g. NFTs).
Testing: Unit tests in miden-standards (metadata storage, recovery); integration tests in miden-testing (MASM getters, faucet + metadata).