feat: increase TokenSymbol max length from 6 to 12 uppercase characters#2420
Open
Farukest wants to merge 3 commits into0xMiden:nextfrom
Open
feat: increase TokenSymbol max length from 6 to 12 uppercase characters#2420Farukest wants to merge 3 commits into0xMiden:nextfrom
TokenSymbol max length from 6 to 12 uppercase characters#2420Farukest wants to merge 3 commits into0xMiden:nextfrom
Conversation
…ters The previous limit of 6 characters (48 bits) was unnecessarily restrictive compared to other blockchains (Solana: 10, Algorand: 8, Ethereum: unlimited). Since uppercase-only encoding (base-26) fits up to 12 characters within a single field element, the limit is increased to 12. Closes 0xMiden#2406
d7a6ffe to
96b1a7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TokenSymbolmax allowed length from 6 to 12 uppercase Latin charactersMAX_ENCODED_VALUEto2481152873203736562(encodes "ZZZZZZZZZZZZ")With uppercase-only encoding (base-26), 12 characters fit within a single field element (61 bits including 4-bit length encoding), making this a non-breaking expansion.
Closes #2406
Test plan
from_static_strconst tests added for 8 and 12 char symbols