chore: refactor miden::protocol from ASSET to ASSET_KEY and ASSET_VALUE#2410
Open
PhilippGackstatter wants to merge 30 commits intopgackst-kernel-asset-key-valuefrom
Open
chore: refactor miden::protocol from ASSET to ASSET_KEY and ASSET_VALUE#2410PhilippGackstatter wants to merge 30 commits intopgackst-kernel-asset-key-valuefrom
miden::protocol from ASSET to ASSET_KEY and ASSET_VALUE#2410PhilippGackstatter wants to merge 30 commits intopgackst-kernel-asset-key-valuefrom
Conversation
599ba84 to
4143ebe
Compare
4143ebe to
d94dc4e
Compare
d94dc4e to
b1af2ca
Compare
igamigo
reviewed
Feb 10, 2026
Collaborator
igamigo
left a comment
There was a problem hiding this comment.
Not a full review yet but leaving some comments, overall looks great.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
miden::protocolasset APIs to takeASSET_KEYandASSET_VALUEinstead of justASSETto adapt to the kernel changes from #2396.This PR, like #2396, also keeps the key and value layout of assets unchanged and only deals with expanding assets from one to two words for simplicity.
Migration
REQUESTED_ASSET. Now it storesREQUESTED_ASSET_KEYandREQUESTED_ASSET_VALUE.miden::standards::wallets::basic::move_asset_to_noteno longer returns parameters (motivated byadd_asset_to_noteprocedure results overhead when calling from Rust #1717).miden::protocol::asset::build_(non_)fungible_asset->miden::protocol::asset::create_(non_)fungible_asset, for consistency with themiden::protocol::faucetprocedures of the same name.create_andbuild_interchangeably in APIs and it would be nice to be more consistent there.miden::protocol::faucet::create_fungible_assetmiden::protocol::faucet::create_non_fungible_assetmiden::protocol::faucet::mintmiden::protocol::faucet::burnmiden::protocol::asset::create_fungible_assetmiden::protocol::asset::create_non_fungible_assetmiden::protocol::native_account::add_assetmiden::protocol::native_account::remove_assetmiden::protocol::output_note::add_assetmiden::standards::wallets::basic::move_asset_to_noteNotable Changes
bridge_out.masmneeded a bigger update:miden::protocol. This logic will change when the layout changes, but some procedure to create a vault key will probably remain at least until generalized assets and maybe beyond.mock::utillibrary to miden-standards to be able to provideexec-wrappers forbasic::wallet::move_asset_to_note.part of #2328