Implement mmNetObject::Predict #171
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First draft. Not sure about the constant (name). The first `ARTSPTR->GetUpdateDelta()` could be put directly in the function call if you prefer.
At the moment there are still some compiler errors related to unresolved external symbols.
0x1F9F1
reviewed
Aug 27, 2025
code/midtown/mmgame/netobject.cpp
Outdated
Comment on lines
32
to
55
| : asNetObject() | ||
| , field_28(0) | ||
| , Flags(0) | ||
| , Score(0) | ||
| , Time(0.0f) | ||
| , LocalData {} | ||
| , Car(nullptr) | ||
| , IsEnabled(false) | ||
| , Active(0) | ||
| , UpdateCount(0) | ||
| , MatrixChanged(false) | ||
| , ActivateTime(0.0f) | ||
| , Steering(0.0f) | ||
| , PrevSteering(0.0f) | ||
| , SteeringDelta(0.0f) | ||
| , Throttle(0.0f) | ||
| , PrevThrottle(0.0f) | ||
| , ThrottleDelta(0.0f) | ||
| , Brakes(0.0f) | ||
| , PrevBrakes(0.0f) | ||
| , BrakesDelta(0.0f) | ||
| , field_BC(0.0f) | ||
| , field_C0(0.0f) | ||
| , Matrix(IDENTITY) |
Owner
There was a problem hiding this comment.
All these members can be directly initialized as part of the member's declaration. Also, you don't need to explicitly call the base classes default constructor.
Owner
There was a problem hiding this comment.
@KcRobin9 you still need to initialize these members, I just mean you can do it as part of the declaration, i.e field_28 {} (for any "default" values false/0/0.0f/nullptr you can use empty brackets rather than i.e field_28 {0}.
Also you still need to have a constructor to reset time_delta since that's not a member.
0x1F9F1
reviewed
Sep 5, 2025
code/midtown/mmgame/netobject.cpp
Outdated
| return; | ||
|
|
||
| LocalData.SenderId = PlayerID; | ||
| LocalData.MessageId = 501; |
Owner
There was a problem hiding this comment.
Can you create an enum for the IDs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft.
Not sure about the constant (name).
The first
ARTSPTR->GetUpdateDelta()could be put directly in the function call if you prefer.