Skip to content

Commit b9de887

Browse files
committed
msglist test [nfc]: Find scroll view more generically
This lets these tests stop caring which specific ScrollView subclass the implementation of MessageList uses.
1 parent f35926d commit b9de887

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

test/widgets/message_list_test.dart

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,9 +103,11 @@ void main() {
103103
.findsOne();
104104
}
105105

106+
ScrollView findScrollView(WidgetTester tester) =>
107+
tester.widget<ScrollView>(find.byWidgetPredicate((w) => w is ScrollView));
108+
106109
ScrollController? findMessageListScrollController(WidgetTester tester) {
107-
final scrollView = tester.widget<CustomScrollView>(find.byType(CustomScrollView));
108-
return scrollView.controller;
110+
return findScrollView(tester).controller;
109111
}
110112

111113
group('MessageListPage', () {
@@ -368,7 +370,7 @@ void main() {
368370

369371
group('fetch older messages on scroll', () {
370372
int? itemCount(WidgetTester tester) =>
371-
tester.widget<CustomScrollView>(find.byType(CustomScrollView)).semanticChildCount;
373+
findScrollView(tester).semanticChildCount;
372374

373375
testWidgets('basic', (tester) async {
374376
await setupMessageListPage(tester, foundOldest: false,

0 commit comments

Comments
 (0)