msglist: Add message to mentions if mentioned

Author: Khader-1

lib/model/message_list.dart

@@ -666,6 +666,25 @@ class MessageListView with ChangeNotifier, _MessageSequence {
     }
   }
 
+  void _addMessageToMentionsIfMentioned(Message message) {
+    if (message.flags.contains(MessageFlag.read)) return;
+    if (!message.flags.contains(MessageFlag.mentioned)) return;
+
+    store.unreads.mentions.add(message.id);
+  }
+
+  @override
+  void _addMessage(Message message) {
+    super._addMessage(message);
+    _addMessageToMentionsIfMentioned(message);
+  }
+
+  @override
+  void _insertAllMessages(int index, Iterable<Message> toInsert) {
+    super._insertAllMessages(index, toInsert);
+    toInsert.forEach(_addMessageToMentionsIfMentioned);
+  }
+
   // Repeal the `@protected` annotation that applies on the base implementation,
   // so we can call this method from [MessageStoreImpl].
   @override

lib/model/unreads.dart

@@ -33,8 +33,6 @@ import 'channel.dart';
 // TODO handle moved messages
 // TODO When [oldUnreadsMissing], if you load a message list with very old unreads,
 //   sync to those unreads, because the user has shown an interest in them.
-// TODO When loading a message list with stream messages, check all the stream
-//   messages and refresh [mentions] (see [mentions] dartdoc).
 class Unreads extends ChangeNotifier {
   factory Unreads({
     required UnreadMessagesSnapshot initial,
@@ -104,7 +102,7 @@ class Unreads extends ChangeNotifier {
   ///   a) the message is edited at all ([UpdateMessageEvent]),
   ///      assuming it still has a direct or wildcard mention after the edit, or
   ///   b) the message gains a direct @-mention ([UpdateMessageFlagsEvent]), or
-  ///   c) TODO unimplemented: the user loads the message in the message list
+  ///   c) the user loads the message in the message list
   /// But otherwise, assume its unread state remains unknown to [mentions].
   ///
   /// [1] This item applies verbatim at Server 8.0+. For older servers, the

test/model/message_list_test.dart

@@ -1665,6 +1665,40 @@ void main() {
       }
     }
   });
+
+  group('_addMessageToMentionsIfMentioned', () {
+    test('is called by fetchInitial', () async {
+      await prepare();
+      final message = eg.streamMessage(flags: [MessageFlag.mentioned]);
+      check(store.unreads.mentions.contains(message.id)).isFalse();
+      await prepareMessages(foundOldest: true, messages: [message]);
+      check(store.unreads.mentions.contains(message.id)).isTrue();
+    });
+
+    test('is called by fetchOlder', () async {
+      final olderMessage = eg.streamMessage(flags: [MessageFlag.mentioned]);
+      await prepare();
+      await prepareMessages(foundOldest: false, messages: [eg.streamMessage()]);
+      connection.prepare(json: olderResult(
+        anchor: 1000, foundOldest: true,
+        messages: [olderMessage],
+      ).toJson());
+
+      check(store.unreads.mentions.contains(olderMessage.id)).isFalse();
+      await model.fetchOlder();
+      check(store.unreads.mentions.contains(olderMessage.id)).isTrue();
+    });
+
+    test('is called by MessageEvent', () async {
+      final newMessage = eg.streamMessage(flags: [MessageFlag.mentioned]);
+      await prepare();
+      await prepareMessages(foundOldest: false, messages: []);
+
+      check(store.unreads.mentions.contains(newMessage.id)).isFalse();
+      await store.handleEvent(MessageEvent(id: 1, message: newMessage));
+      check(store.unreads.mentions.contains(newMessage.id)).isTrue();
+    });
+  });
 }
 
 void checkInvariants(MessageListView model) {