Stop reimplementing $zle_highlight

[danielshahaf]

Currently z-sy-h reimplements $zle_highlight's semantics:

zsh-syntax-highlighting/zsh-syntax-highlighting.zsh

Lines 163 to 193 in 91d2eea

	# Re-apply zle_highlight settings
	# region
	() {
	(( REGION_ACTIVE )) || return
	integer min max
	if (( MARK > CURSOR )) ; then
	min=$CURSOR max=$MARK
	else
	min=$MARK max=$CURSOR
	fi
	if (( REGION_ACTIVE == 1 )); then
	[[ $KEYMAP = vicmd ]] && (( max++ ))
	elif (( REGION_ACTIVE == 2 )); then
	local needle=$'\n'
	# CURSOR and MARK are 0 indexed between letters like region_highlight
	# Do not include the newline in the highlight
	(( min = ${BUFFER[(Ib:min:)$needle]} ))
	(( max = ${BUFFER[(ib:max:)$needle]} - 1 ))
	fi
	_zsh_highlight_apply_zle_highlight region standout "$min" "$max"
	}
	# yank / paste (zsh-5.1.1 and newer)
	(( $+YANK_ACTIVE )) && (( YANK_ACTIVE )) && _zsh_highlight_apply_zle_highlight paste standout "$YANK_START" "$YANK_END"
	# isearch
	(( $+ISEARCHMATCH_ACTIVE )) && (( ISEARCHMATCH_ACTIVE )) && _zsh_highlight_apply_zle_highlight isearch underline "$ISEARCHMATCH_START" "$ISEARCHMATCH_END"
	# suffix
	(( $+SUFFIX_ACTIVE )) && (( SUFFIX_ACTIVE )) && _zsh_highlight_apply_zle_highlight suffix bold "$SUFFIX_START" "$SUFFIX_END"

Work with zsh upstream to resolve this duplication.

See #418 (comment).

[danielshahaf]

Triage: The current approach isn't elegant, but is good enough so long as zsh doesn't extend the $zle_highlight syntax in a manner that's non-trivial to reimplement in script code, and that isn't in the offing. We can cross that bridge when we come to it. Leaving unmilestoned.

[okapia]

The layer= feature merged upstream in zsh-workers/52500 (85545af42) is intended to provide a solution to this and other related issues. There's not been any feedback. Perhaps this project's developers are better qualified to consider that new feature and other new highlighting related features?

[danielshahaf]

Thanks for the heads up, Oliver. I'm afraid I don't have the brainwidth to follow -workers@ presently, but perhaps one of the other developers can chime in. I do look forward to reading up on all the recent changes when I have time. I did quickly grep through past interplugin interaction issues but have nothing to report. okapia wrote on Mon, 12 Feb 2024 22:53 +00:00:

…

The `layer=` feature merged upstream in zsh-workers/52500 (85545af42) is intended to provide a solution to this and other related issues. There's not been any feedback. Perhaps this project's developers are better qualified to consider that new feature and other new highlighting related features? -- Reply to this email directly or view it on GitHub: #745 (comment) You are receiving this because you authored the thread. Message ID: ***@***.***>