-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use OMZ completions-dir.txt to improve installation #835
Conversation
Waiting for #603 before marking as ready to review. |
My last commit addresses the concern raised in ohmyzsh/ohmyzsh#10412 (comment), where multiple entries of The approach I used was taken from https://unix.stackexchange.com/a/62581/427940, and I would really like to know if there better or cleaner approaches out there for handling such a situation in ZSH. |
Hi, I understand this |
Specifically for OMZ for now, this is a new feature that I'm introducing at ohmyzsh/ohmyzsh#10565. Other package managers can also make use of it if they want. Also, isn't https://github.com/zsh-users/zsh-completions/blob/master/zsh-completions.plugin.zsh already specific to OMZ? |
The Does anyone else have thoughts on this ? |
@nicoulaj just to mention, I totally understand your reasonings. I'm just trying to solve an outstanding incompatibility issue between this project and OMZ. But any better ideas are 100% welcome, of course. |
Please don't. OMZ should deal with its own problems without the expense of other projects or users who don't use OMZ. |
I agree, this solution is not elegant and any changes that we make need to be adopted by the majority of plugin managers. It seems that most PMs support changing This is not taken into account in OMZ because the If there is a solution to allow support for completion changes in the .plugin.zsh file while running |
This implements ohmyzsh/ohmyzsh#10565.
Fixes #603.