Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant DB migration in start script #432

Open
zwolf opened this issue Jan 22, 2025 · 0 comments
Open

Redundant DB migration in start script #432

zwolf opened this issue Jan 22, 2025 · 0 comments

Comments

@zwolf
Copy link
Member

zwolf commented Jan 22, 2025

There is a db:migrate step in the start_puma.rb script that is run when the app is initialized (when environment != development). Since migrations for both staging and production were extracted out to run as kubernetes jobs by a github action, this is redundant. It should always be a no-op since the migration step immediately precedes it in both deploy workflows, but should be removed for clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant