Proposal await dictionary allSettledKeyed method

slowcheetah · slowcheetah · commit 7782c0c9ef04 · 2025-11-01T14:17:38.000+07:00
diff --git a/docs/web/docs/features/proposals/await-dictionary.md b/docs/web/docs/features/proposals/await-dictionary.md
@@ -3,21 +3,26 @@
 [Proposal repo](https://github.com/tc39/proposal-await-dictionary)
 
 ## Modules
-[`esnext.promise.all-keyed`](https://github.com/zloirock/core-js/blob/v4/packages/core-js/modules/esnext.promise.all-keyed.js)
+[`esnext.promise.all-keyed`](https://github.com/zloirock/core-js/blob/v4/packages/core-js/modules/esnext.promise.all-keyed.js), [`esnext.promise.all-settled-keyed`](https://github.com/zloirock/core-js/blob/v4/packages/core-js/modules/esnext.promise.all-settled-keyed.js)
 
 ## Built-ins signatures
 ```ts
 class Promise {
   allKeyed<T extends Record<string, unknown>>(
     obj: T
   ): Promise<{ [K in keyof T]: Awaited<T[K]> }>;
+
+  allSettledKeyed<T extends Record<string, unknown>>(
+    obj: T
+  ): Promise<{ [K in keyof T]: PromiseSettledResult<Awaited<T[K]>> }>;
 }
 ```
 
 ## [Entry points]({docs-version}/docs/usage#h-entry-points)
 ```ts
 core-js/proposals/promise-all-keyed
 core-js(-pure)/full/promise/all-keyed
+core-js(-pure)/full/promise/all-settled-keyed
 ```
 
 ## Examples
@@ -27,4 +32,10 @@ await Promise.allKeyed({
   b: Promise.resolve(2),
   c: 3,
 }); // => { a: 1, b: 2, c: 3 }
+
+await Promise.allSettledKeyed({
+  a: Promise.resolve(1),
+  b: Promise.reject(2),
+  c: 3,
+}); // => { a: { status: "fulfilled", value: 1 }, b: { status: "rejected", reasone: 2 }, c: { status: "fulfilled", value: 3 } }
 ```
diff --git a/packages/core-js-compat/src/built-in-definitions.mjs b/packages/core-js-compat/src/built-in-definitions.mjs
@@ -154,6 +154,7 @@ export const StaticProperties = {
     all: 'promise/all',
     allKeyed: 'promise/all-keyed',
     allSettled: 'promise/all-settled',
+    allSettledKeyed: 'promise/all-settled-keyed',
     any: 'promise/any',
     race: 'promise/race',
     try: 'promise/try',
diff --git a/packages/core-js-compat/src/data.mjs b/packages/core-js-compat/src/data.mjs
@@ -2391,6 +2391,8 @@ export const data = {
   },
   'esnext.promise.all-keyed': {
   },
+  'esnext.promise.all-settled-keyed': {
+  },
   'esnext.set.from': {
   },
   'esnext.set.of': {
diff --git a/packages/core-js/modules/esnext.promise.all-settled-keyed.js b/packages/core-js/modules/esnext.promise.all-settled-keyed.js
@@ -0,0 +1,71 @@
+'use strict';
+var $ = require('../internals/export');
+var aCallable = require('../internals/a-callable');
+var anObject = require('../internals/an-object');
+var call = require('../internals/function-call');
+var createProperty = require('../internals/create-property');
+var getBuiltInStaticMethod = require('../internals/get-built-in-static-method');
+var getOwnPropertyDescriptor = require('../internals/object-get-own-property-descriptor');
+var newPromiseCapabilityModule = require('../internals/new-promise-capability');
+var perform = require('../internals/perform');
+var uncurryThis = require('../internals/function-uncurry-this');
+
+var create = Object.create;
+var forEach = uncurryThis([].forEach);
+// dependency: es.reflect.own-keys
+var ownKeys = getBuiltInStaticMethod('Reflect', 'ownKeys');
+
+// `Promise.allSettledKeyed` method
+// https://tc39.es/proposal-await-dictionary
+$({ target: 'Promise', stat: true, forced: true }, {
+  allSettledKeyed: function allSettledKeyed(promises) {
+    var C = this;
+    // dependency: es.promise.constructor
+    // dependency: es.promise.catch
+    // dependency: es.promise.finally
+    // dependency: es.promise.resolve
+    var capability = newPromiseCapabilityModule.f(C);
+    var resolve = capability.resolve;
+    var reject = capability.reject;
+    var result = perform(function () {
+      var wrapResolve = function () {
+        var res = create(null);
+        forEach(keys, function (k, idx) {
+          createProperty(res, k, values[idx]);
+        });
+        resolve(res);
+      };
+      var promiseResolve = aCallable(C.resolve);
+      var allKeys = ownKeys(anObject(promises));
+      var keys = [];
+      var values = [];
+      var remaining = 1;
+      var counter = 0;
+      forEach(allKeys, function (key) {
+        var desc = getOwnPropertyDescriptor.f(promises, key);
+        if (desc && desc.enumerable) {
+          var index = counter;
+          var alreadyCalled = false;
+          remaining++;
+          keys[index] = key;
+          values[index] = undefined;
+          call(promiseResolve, C, promises[key]).then(function (value) {
+            if (alreadyCalled) return;
+            alreadyCalled = true;
+            values[index] = { status: 'fulfilled', value: value };
+            --remaining || wrapResolve();
+          }, function (error) {
+            if (alreadyCalled) return;
+            alreadyCalled = true;
+            values[index] = { status: 'rejected', reason: error };
+            --remaining || wrapResolve();
+          });
+          counter++;
+        }
+      });
+      --remaining || wrapResolve();
+    });
+    if (result.error) reject(result.value);
+    return capability.promise;
+  },
+});
diff --git a/scripts/build-entries/entries-definitions.mjs b/scripts/build-entries/entries-definitions.mjs
@@ -1929,6 +1929,12 @@ export const features = {
     namespace: 'Promise',
     name: 'allSettled',
   },
+  'promise/all-settled-keyed': {
+    modules: ['esnext.promise.all-settled-keyed'],
+    template: $staticWithContext,
+    namespace: 'Promise',
+    name: 'allSettledKeyed',
+  },
   'promise/any': {
     modules: ['es.promise.any'],
     template: $staticWithContext,
@@ -3541,6 +3547,7 @@ export const proposals = {
     stage: 1,
     modules: [
       'esnext.promise.all-keyed',
+      'esnext.promise.all-settled-keyed',
     ],
   },
   'promise-all-settled': {
diff --git a/tests/babel-plugin/fixtures/entry-global/import-full-chrome-135-v4.0/output.mjs b/tests/babel-plugin/fixtures/entry-global/import-full-chrome-135-v4.0/output.mjs
@@ -44,6 +44,7 @@ import "core-js/modules/esnext.map.get-or-insert-computed";
 import "core-js/modules/esnext.map.of";
 import "core-js/modules/esnext.number.clamp";
 import "core-js/modules/esnext.promise.all-keyed";
+import "core-js/modules/esnext.promise.all-settled-keyed";
 import "core-js/modules/esnext.set.from";
 import "core-js/modules/esnext.set.of";
 import "core-js/modules/esnext.string.cooked";
diff --git a/tests/babel-plugin/fixtures/entry-global/import-full-chrome-135-v4.999/output.mjs b/tests/babel-plugin/fixtures/entry-global/import-full-chrome-135-v4.999/output.mjs
@@ -44,6 +44,7 @@ import "core-js/modules/esnext.map.get-or-insert-computed";
 import "core-js/modules/esnext.map.of";
 import "core-js/modules/esnext.number.clamp";
 import "core-js/modules/esnext.promise.all-keyed";
+import "core-js/modules/esnext.promise.all-settled-keyed";
 import "core-js/modules/esnext.set.from";
 import "core-js/modules/esnext.set.of";
 import "core-js/modules/esnext.string.cooked";
diff --git a/tests/babel-plugin/fixtures/entry-global/import-full-ie11-v4.0/output.mjs b/tests/babel-plugin/fixtures/entry-global/import-full-ie11-v4.0/output.mjs
@@ -313,6 +313,7 @@ import "core-js/modules/esnext.map.get-or-insert-computed";
 import "core-js/modules/esnext.map.of";
 import "core-js/modules/esnext.number.clamp";
 import "core-js/modules/esnext.promise.all-keyed";
+import "core-js/modules/esnext.promise.all-settled-keyed";
 import "core-js/modules/esnext.set.from";
 import "core-js/modules/esnext.set.of";
 import "core-js/modules/esnext.string.cooked";
diff --git a/tests/babel-plugin/fixtures/entry-global/import-full-ie11-v4.999/output.mjs b/tests/babel-plugin/fixtures/entry-global/import-full-ie11-v4.999/output.mjs
@@ -313,6 +313,7 @@ import "core-js/modules/esnext.map.get-or-insert-computed";
 import "core-js/modules/esnext.map.of";
 import "core-js/modules/esnext.number.clamp";
 import "core-js/modules/esnext.promise.all-keyed";
+import "core-js/modules/esnext.promise.all-settled-keyed";
 import "core-js/modules/esnext.set.from";
 import "core-js/modules/esnext.set.of";
 import "core-js/modules/esnext.string.cooked";
diff --git a/tests/babel-plugin/fixtures/entry-global/require-full-chrome-135-v4.0/output.mjs b/tests/babel-plugin/fixtures/entry-global/require-full-chrome-135-v4.0/output.mjs
@@ -44,6 +44,7 @@ import "core-js/modules/esnext.map.get-or-insert-computed";
 import "core-js/modules/esnext.map.of";
 import "core-js/modules/esnext.number.clamp";
 import "core-js/modules/esnext.promise.all-keyed";
+import "core-js/modules/esnext.promise.all-settled-keyed";
 import "core-js/modules/esnext.set.from";
 import "core-js/modules/esnext.set.of";
 import "core-js/modules/esnext.string.cooked";
diff --git a/tests/babel-plugin/fixtures/entry-global/require-full-chrome-135-v4.999/output.mjs b/tests/babel-plugin/fixtures/entry-global/require-full-chrome-135-v4.999/output.mjs
@@ -44,6 +44,7 @@ import "core-js/modules/esnext.map.get-or-insert-computed";
 import "core-js/modules/esnext.map.of";
 import "core-js/modules/esnext.number.clamp";
 import "core-js/modules/esnext.promise.all-keyed";
+import "core-js/modules/esnext.promise.all-settled-keyed";
 import "core-js/modules/esnext.set.from";
 import "core-js/modules/esnext.set.of";
 import "core-js/modules/esnext.string.cooked";
diff --git a/tests/babel-plugin/fixtures/entry-global/require-full-ie11-v4.0/output.mjs b/tests/babel-plugin/fixtures/entry-global/require-full-ie11-v4.0/output.mjs
@@ -313,6 +313,7 @@ import "core-js/modules/esnext.map.get-or-insert-computed";
 import "core-js/modules/esnext.map.of";
 import "core-js/modules/esnext.number.clamp";
 import "core-js/modules/esnext.promise.all-keyed";
+import "core-js/modules/esnext.promise.all-settled-keyed";
 import "core-js/modules/esnext.set.from";
 import "core-js/modules/esnext.set.of";
 import "core-js/modules/esnext.string.cooked";
diff --git a/tests/babel-plugin/fixtures/entry-global/require-full-ie11-v4.999/output.mjs b/tests/babel-plugin/fixtures/entry-global/require-full-ie11-v4.999/output.mjs
@@ -313,6 +313,7 @@ import "core-js/modules/esnext.map.get-or-insert-computed";
 import "core-js/modules/esnext.map.of";
 import "core-js/modules/esnext.number.clamp";
 import "core-js/modules/esnext.promise.all-keyed";
+import "core-js/modules/esnext.promise.all-settled-keyed";
 import "core-js/modules/esnext.set.from";
 import "core-js/modules/esnext.set.of";
 import "core-js/modules/esnext.string.cooked";
diff --git a/tests/compat/tests.js b/tests/compat/tests.js
@@ -1882,6 +1882,9 @@ GLOBAL.tests = {
   'esnext.promise.all-keyed': function () {
     return Promise.allKeyed;
   },
+  'esnext.promise.all-settled-keyed': function () {
+    return Promise.allSettledKeyed;
+  },
   'esnext.set.from': function () {
     return Set.from;
   },
diff --git a/tests/eslint/eslint.config.js b/tests/eslint/eslint.config.js
@@ -1334,6 +1334,7 @@ const forbidCompletelyNonExistentBuiltIns = {
   ] }],
   'es/no-nonstandard-promise-properties': [ERROR, { allow: [
     'allKeyed',
+    'allSettledKeyed',
   ] }],
   'es/no-nonstandard-reflect-properties': [ERROR, { allow: [
     // TODO: drop from `core-js@4`
diff --git a/tests/unit-global/esnext.promise.all-settled-keyed.js b/tests/unit-global/esnext.promise.all-settled-keyed.js
@@ -0,0 +1,152 @@
+QUnit.test('Promise.allSettledKeyed', assert => {
+  assert.isFunction(Promise.allSettledKeyed);
+  assert.arity(Promise.allSettledKeyed, 1);
+  assert.looksNative(Promise.allSettledKeyed);
+  assert.nonEnumerable(Promise, 'allSettledKeyed');
+  assert.true(Promise.allSettledKeyed({}) instanceof Promise, 'returns a promise');
+});
+
+QUnit.test('Promise.allSettledKeyed, resolved', assert => {
+  return Promise.allSettledKeyed({
+    a: Promise.resolve(1),
+    b: Promise.resolve(2),
+    c: Promise.resolve(3),
+  }).then(it => {
+    assert.deepEqual(it, {
+      a: { value: 1, status: 'fulfilled' },
+      b: { value: 2, status: 'fulfilled' },
+      c: { value: 3, status: 'fulfilled' },
+    }, 'resolved with a correct value');
+  });
+});
+
+QUnit.test('Promise.allSettledKeyed, resolved with rejection', assert => {
+  return Promise.allSettledKeyed({
+    a: Promise.resolve(1),
+    b: Promise.reject(2),
+    c: Promise.resolve(3),
+  }).then(it => {
+    assert.deepEqual(it, {
+      a: { value: 1, status: 'fulfilled' },
+      b: { reason: 2, status: 'rejected' },
+      c: { value: 3, status: 'fulfilled' },
+    }, 'resolved with a correct value');
+  });
+});
+
+QUnit.test('Promise.allSettledKeyed, rejected', assert => {
+  return Promise.allSettledKeyed().then(() => {
+    assert.avoid();
+  }, () => {
+    assert.required('rejected as expected');
+  });
+});
+
+QUnit.test('Promise.allSettledKeyed, resolved with empty object', assert => {
+  return Promise.allSettledKeyed({}).then(it => {
+    assert.deepEqual(it, {}, 'resolved with a correct value');
+  });
+});
+
+QUnit.test('Promise.allSettledKeyed, resolved with hidden attributes', assert => {
+  const obj = Object.create({ proto: Promise.resolve('hidden') });
+  obj.visible = Promise.resolve(42);
+  Object.defineProperty(obj, 'invisible', { value: Promise.resolve(99), enumerable: false });
+  return Promise.allSettledKeyed(obj).then(it => {
+    assert.deepEqual(it, { visible: { status: 'fulfilled', value: 42 } }, 'ignores prototype/invisible');
+  });
+});
+
+QUnit.test('Promise.allSettledKeyed, rejected on incorrect input', assert => {
+  return Promise.allSettledKeyed('string').then(() => {
+    assert.avoid();
+  }, error => {
+    assert.true(error instanceof TypeError, 'error is TypeError');
+    assert.required('rejected as expected');
+  });
+});
+
+QUnit.test('Promise.allSettledKeyed, resolved with timeouts', assert => {
+  return Promise.allSettledKeyed({
+    a: Promise.resolve(1),
+    b: new Promise(resolve => setTimeout(() => resolve(2), 10)),
+    c: Promise.resolve(3),
+  }).then(it => {
+    assert.deepEqual(it, {
+      a: { value: 1, status: 'fulfilled' },
+      b: { value: 2, status: 'fulfilled' },
+      c: { value: 3, status: 'fulfilled' },
+    }, 'keeps correct mapping, even with delays');
+  });
+});
+
+QUnit.test('Promise.allSettledKeyed, subclassing', assert => {
+  const { allSettledKeyed, resolve } = Promise;
+  function SubPromise(executor) {
+    executor(() => { /* empty */ }, () => { /* empty */ });
+  }
+  SubPromise.resolve = resolve.bind(Promise);
+  assert.true(allSettledKeyed.call(SubPromise, { a: 1, b: 2, c: 3 }) instanceof SubPromise, 'subclassing, `this` pattern');
+
+  function FakePromise1() { /* empty */ }
+  function FakePromise2(executor) {
+    executor(null, () => { /* empty */ });
+  }
+  function FakePromise3(executor) {
+    executor(() => { /* empty */ }, null);
+  }
+  FakePromise1.resolve = FakePromise2.resolve = FakePromise3.resolve = resolve.bind(Promise);
+  assert.throws(() => {
+    allSettledKeyed.call(FakePromise1, { a: 1, b: 2, c: 3 });
+  }, 'NewPromiseCapability validations, #1');
+  assert.throws(() => {
+    allSettledKeyed.call(FakePromise2, { a: 1, b: 2, c: 3 });
+  }, 'NewPromiseCapability validations, #2');
+  assert.throws(() => {
+    allSettledKeyed.call(FakePromise3, { a: 1, b: 2, c: 3 });
+  }, 'NewPromiseCapability validations, #3');
+});
+
+QUnit.test('Promise.allSettledKeyed, without constructor context', assert => {
+  const { allSettledKeyed } = Promise;
+  assert.throws(() => allSettledKeyed({ a: Promise.resolve(1) }), TypeError, 'Throws if called without a constructor context');
+  assert.throws(() => allSettledKeyed.call(null, { a: Promise.resolve(1) }), TypeError, 'Throws if called with null as this');
+});
+
+QUnit.test('Promise.allSettledKeyed, result object has null prototype', assert => {
+  return Promise.allSettledKeyed({
+    a: Promise.resolve(1),
+    b: Promise.resolve(2),
+  }).then(result => {
+    assert.strictEqual(
+      Object.getPrototypeOf(result),
+      null,
+      'Result object has null prototype',
+    );
+  });
+});
+
+QUnit.test('Promise.allSettledKeyed, symbol keys', assert => {
+  const symA = Symbol('A');
+  const symB = Symbol('B');
+  return Promise.allSettledKeyed({
+    a: Promise.resolve(1),
+    [symA]: Promise.resolve(2),
+    [symB]: Promise.resolve(3),
+  }).then(it => {
+    assert.deepEqual(it.a, { status: 'fulfilled', value: 1 }, 'string key');
+    assert.deepEqual(it[symA], { status: 'fulfilled', value: 2 }, 'symbol key A');
+    assert.deepEqual(it[symB], { status: 'fulfilled', value: 3 }, 'symbol key B');
+  });
+});
+
+QUnit.test('Promise.allSettledKeyed, keys order', assert => {
+  return Promise.allSettledKeyed({
+    a: Promise.resolve(1),
+    b: new Promise(resolve => setTimeout(() => resolve(2), 10)),
+    c: Promise.resolve(3),
+  }).then(it => {
+    const actualKeys = Object.keys(it);
+    assert.deepEqual(actualKeys, ['a', 'b', 'c'], 'correct order in the case when promises resolves in different order');
+  });
+});
diff --git a/tests/unit-pure/esnext.promise.all-settled-keyed.js b/tests/unit-pure/esnext.promise.all-settled-keyed.js
