Fix test crypt.rand: random_bytes[0] can be 0, std::string(random_bytes)

sergio-nsk · nmoinvaz · commit 1e2d77345a56 · 2023-05-17T15:50:06.000-07:00
gets empty C string.
diff --git a/test/test_crypt.cc b/test/test_crypt.cc
@@ -44,7 +44,7 @@ TEST(crypt, rand) {
 
     EXPECT_EQ(mz_crypt_rand(random_bytes, sizeof(random_bytes)), sizeof(random_bytes));
 
-    EXPECT_NE(std::string((char *)random_bytes).find_first_not_of('\0'), std::string::npos);
+    EXPECT_NE(std::string((char *)random_bytes, sizeof(random_bytes)).find_first_not_of('\0'), std::string::npos);
 }
 
 TEST(crypt, sha1) {

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ TEST(crypt, rand) {`
`44`	`44`
`45`	`45`	`EXPECT_EQ(mz_crypt_rand(random_bytes, sizeof(random_bytes)), sizeof(random_bytes));`
`46`	`46`
`47`		`- EXPECT_NE(std::string((char *)random_bytes).find_first_not_of('\0'), std::string::npos);`
	`47`	`+ EXPECT_NE(std::string((char *)random_bytes, sizeof(random_bytes)).find_first_not_of('\0'), std::string::npos);`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`TEST(crypt, sha1) {`