Question about locality in sequential editing

[yyotta]

Hi there,
I noticed a potential issue with how locality is measured during sequential editing. Since copy=False

EasyEdit/easyeditor/editors/multimodal_editor.py

Line 219 in a642707

copy=False,

is set in self.apply_algo, self.model is modified in-place, becoming identical to edited_model. As a result, it is no longer the original model. Does this violate the principle of locality?

EasyEdit/easyeditor/editors/multimodal_editor.py

Line 276 in a642707

"pre": compute_multimodal_hf_edit_results(self.model, self.model_name, self.hparams, self.tok,

Simply setting copy=True wouldn't fix this, as that would treat the process as multiple independent single edits rather than a sequence.
I think we should explicitly save the original model or cache its outputs before the editing loop starts. Could you confirm if my reasoning is correct, please? Thanks!

[littlefive5]

Thanks, your concern seems right, we will modify this.