allow unreachable code in a branch of a cfg_if_expr!

Author: cosmicexplorer

examples/write_dir.rs

@@ -51,21 +51,21 @@ fn real_main() -> i32 {
             #[cfg(feature = "bzip2")] => zip::CompressionMethod::Bzip2,
             _ => {
                 println!("The `bzip2` feature is not enabled");
-                std::process::exit(1);
+                std::process::exit(1)
             }
         },
         CompressionMethod::Xz => cfg_if_expr! {
             #[cfg(feature = "xz")] => zip::CompressionMethod::Xz,
             _ => {
                 println!("The `xz` feature is not enabled");
-                std::process::exit(1);
+                std::process::exit(1)
             }
         },
         CompressionMethod::Zstd => cfg_if_expr! {
             #[cfg(feature = "zstd")] => zip::CompressionMethod::Zstd,
             _ => {
                 println!("The `zstd` feature is not enabled");
-                std::process::exit(1);
+                std::process::exit(1)
             }
         },
     };

src/macros.rs

@@ -106,9 +106,15 @@ macro_rules! cfg_if_expr {
             $crate::cfg_if_expr! {
                 @__items ();
                 $(
-                    (( $i_meta ) ( return $i_val ; )) ,
+                    (( $i_meta ) (
+                        #[allow(unreachable_code)]
+                        return $i_val ;
+                    )) ,
                 )+
-                    (() ( return $rem_val ; )) ,
+                    (() (
+                        #[allow(unreachable_code)]
+                        return $rem_val ;
+                    )) ,
             }
         })()
     };
@@ -121,7 +127,10 @@ macro_rules! cfg_if_expr {
             $crate::cfg_if_expr! {
                 @__items ();
                 $(
-                    (( $i_meta ) ( return $i_val ; )) ,
+                    (( $i_meta ) (
+                        #[allow(unreachable_code)]
+                        return $i_val ;
+                    )) ,
                 )+
             }
         })()

src/read.rs

@@ -172,10 +172,10 @@ impl<'a, R: Read> CryptoReader<'a, R> {
     }
 
     /// Returns `true` if the data is encrypted using AE2.
+    #[allow(clippy::needless_return)]
     pub const fn is_ae2_encrypted(&self) -> bool {
         cfg_if! {
             if #[cfg(feature = "aes-crypto")] {
-                #[allow(clippy::needless_return)]
                 return matches!(
                     self,
                     CryptoReader::Aes {