From 8cda120cf3ee607c9b65243e973cdb8a1fabcad9 Mon Sep 17 00:00:00 2001 From: Vincenzo Palazzo Date: Fri, 22 Jul 2022 10:45:06 +0100 Subject: [PATCH 1/2] prepare last versions beta Signed-off-by: Vincenzo Palazzo --- docs/dev/MAINTAINERS.md | 12 +++++++----- packages/graphql/CHANGELOG.md | 9 +++++++++ packages/graphql/changelog.json | 4 ++-- packages/graphql/pubspec.yaml | 2 +- packages/graphql_flutter/CHANGELOG.md | 6 ++++++ packages/graphql_flutter/changelog.json | 4 ++-- packages/graphql_flutter/pubspec.yaml | 2 +- 7 files changed, 28 insertions(+), 11 deletions(-) diff --git a/docs/dev/MAINTAINERS.md b/docs/dev/MAINTAINERS.md index 35b2ace90..a3550bd21 100644 --- a/docs/dev/MAINTAINERS.md +++ b/docs/dev/MAINTAINERS.md @@ -30,10 +30,10 @@ Sometimes the right way is unclear, so it’s best not to spend time on it. It ### Use of `FIXME` There are two cases in which you should use a `/* FIXME: */` -comment: one is where an optimization is possible, but it’s not clear that it’s yet worthwhile, +comment: one is where an optimization is possible, but it’s not clear that it’s yet worthwhile, and the second one is to note an ugly corner case which could be improved (and may be in a following patch). -There are always compromises in code: eventually it needs to ship. `FIXME` is grep-fodder for yourself and others, +There are always compromises in code: eventually it needs to ship. `FIXME` is grep-fodder for yourself and others, as well as useful warning signs if we later encounter an issue in some part of the code. ### Write For Today: Unused Code Is Buggy Code @@ -87,6 +87,8 @@ The version in our package.json gets copied to the one we publish, and users nee - **feat**: A new feature - **fix**: A bug fix +- **deprecate**: Deprecate a feature and start to the removing process (3 official release or 1 major release) +- **remove**: End of life for the feature. ### Scopes @@ -117,7 +119,7 @@ The stacktrace is the following one } expected `Foo` not `Foo` - both operands must be the same type for operator overloading 11 | } - 12 | + 12 | 13 | fn (_ Foo) == (_ Foo) bool { | ~~~ 14 | return true @@ -142,8 +144,8 @@ To prepare the release the following steps are required: - `make {changelog_client|changelog_flutter|changelog}`, where - `changelog_client`: generate the changelog for graphql; - `changelog_flutter`: generate the changelog for graphql_flutter; - - `changelog`: generate both changelos. -- Make the Github release: To release a single package we need to create a release with the following tag `{package_name}-v{version_number}`, and + - `changelog`: generate both changelos. +- Make the Github release: To release a single package we need to create a release with the following tag `{package_name}-v{version_number}`, and if we make a release with the tag `v{version_number}` this will release all the packages (useful for a major release of the package). diff --git a/packages/graphql/CHANGELOG.md b/packages/graphql/CHANGELOG.md index d3886e2ad..e33b3c9d5 100644 --- a/packages/graphql/CHANGELOG.md +++ b/packages/graphql/CHANGELOG.md @@ -1,3 +1,12 @@ +# v5.1.2-beta.4 + +## Added +- Introduce a new class `GraphQLProtocol` with bettern n… ([commit](https://github.com/zino-hofmann/graphql-flutter/commit/e59d40693125c8502d7fd7dcdb4817ece4645052)). @vincenzopalazzo 22-07-2022 + +## Deprecated +- deprecate the `SocketSubProtocol` to improve naming ([commit](https://github.com/zino-hofmann/graphql-flutter/commit/2afd58362b2b107197004a14a61152ec8985fa1f)). @vincenzopalazzo 22-07-2022 + + # v5.1.2-beta.3 ## Fixes diff --git a/packages/graphql/changelog.json b/packages/graphql/changelog.json index 72246cdea..e68e07fd5 100644 --- a/packages/graphql/changelog.json +++ b/packages/graphql/changelog.json @@ -1,13 +1,13 @@ { "package_name": "graphql", - "version": "v5.1.2-beta.3", + "version": "v5.1.2-beta.4", "api": { "name": "github", "repository": "zino-hofmann/graphql-flutter", "branch": "main" }, "generation_method": { - "name": "header", + "name": "semver-v2", "header_filter": true }, "serialization_method": { diff --git a/packages/graphql/pubspec.yaml b/packages/graphql/pubspec.yaml index 4c529c6ac..8babc3290 100644 --- a/packages/graphql/pubspec.yaml +++ b/packages/graphql/pubspec.yaml @@ -1,6 +1,6 @@ name: graphql description: A stand-alone GraphQL client for Dart, bringing all the features from a modern GraphQL client to one easy to use package. -version: 5.1.2-beta.3 +version: 5.1.2-beta.4 homepage: https://github.com/zino-app/graphql-flutter/tree/master/packages/graphql dependencies: diff --git a/packages/graphql_flutter/CHANGELOG.md b/packages/graphql_flutter/CHANGELOG.md index 4dd2bf163..86d64164f 100644 --- a/packages/graphql_flutter/CHANGELOG.md +++ b/packages/graphql_flutter/CHANGELOG.md @@ -1,3 +1,9 @@ +# v5.1.1-beta.4 + +## Fixed +- fix wrong default policy merging in useWatchQue… ([commit](https://github.com/zino-hofmann/graphql-flutter/commit/e4b864b0467a3558dcbbb0b40d63e67aa76f30f8)). @dehypnosis 22-07-2022 + + # v5.1.1-beta.3 ## New Feature diff --git a/packages/graphql_flutter/changelog.json b/packages/graphql_flutter/changelog.json index 074090d24..3ea8f73eb 100644 --- a/packages/graphql_flutter/changelog.json +++ b/packages/graphql_flutter/changelog.json @@ -1,13 +1,13 @@ { "package_name": "graphql_flutter", - "version": "v5.1.1-beta.3", + "version": "v5.1.1-beta.4", "api": { "name": "github", "repository": "zino-hofmann/graphql-flutter", "branch": "main" }, "generation_method": { - "name": "header", + "name": "semver-v2", "header_filter": true }, "serialization_method": { diff --git a/packages/graphql_flutter/pubspec.yaml b/packages/graphql_flutter/pubspec.yaml index 99bc109f8..de23784cb 100644 --- a/packages/graphql_flutter/pubspec.yaml +++ b/packages/graphql_flutter/pubspec.yaml @@ -1,6 +1,6 @@ name: graphql_flutter description: A GraphQL client for Flutter, bringing all the features from a modern GraphQL client to one easy to use package. -version: 5.1.1-beta.3 +version: 5.1.1-beta.4 homepage: https://github.com/zino-app/graphql-flutter/tree/master/packages/graphql_flutter dependencies: From a564c51633ee216e27438e554ccfae13d1bdc79b Mon Sep 17 00:00:00 2001 From: Vincenzo Palazzo Date: Fri, 22 Jul 2022 21:15:53 +0100 Subject: [PATCH 2/2] add #1186 Signed-off-by: Vincenzo Palazzo # Title: Signed-off-by: Vincenzo Palazzo --- .releaserc.yaml | 16 ---------------- packages/graphql/CHANGELOG.md | 5 ++++- 2 files changed, 4 insertions(+), 17 deletions(-) delete mode 100644 .releaserc.yaml diff --git a/.releaserc.yaml b/.releaserc.yaml deleted file mode 100644 index b2782394a..000000000 --- a/.releaserc.yaml +++ /dev/null @@ -1,16 +0,0 @@ -branches: - - master - - name: beta - prerelease: true -plugins: - - "@semantic-release/commit-analyzer" - - "@semantic-release/release-notes-generator" - - - "@semantic-release/changelog" - - changelogFile: "packages/graphql/CHANGELOG.md" - - - "@semantic-release/changelog" - - changelogFile: "packages/graphql_flutter/CHANGELOG.md" - - - "@semantic-release/git" - - assets: - - "packages/graphql/CHANGELOG.md" - - "packages/graphql_flutter/CHANGELOG.md" - - "@semantic-release/github" diff --git a/packages/graphql/CHANGELOG.md b/packages/graphql/CHANGELOG.md index e33b3c9d5..20261005c 100644 --- a/packages/graphql/CHANGELOG.md +++ b/packages/graphql/CHANGELOG.md @@ -1,7 +1,10 @@ # v5.1.2-beta.4 +## Fixed +- fix `SocketClient` to close subscription on socket close ([commit](https://github.com/zino-hofmann/graphql-flutter/commit/45f88f6886e5175162caaa6944e69a11ef7fe346)). @qbx2 22-07-2022 + ## Added -- Introduce a new class `GraphQLProtocol` with bettern n… ([commit](https://github.com/zino-hofmann/graphql-flutter/commit/e59d40693125c8502d7fd7dcdb4817ece4645052)). @vincenzopalazzo 22-07-2022 +- Introduce a new class `GraphQLProtocol` with better naming ([commit](https://github.com/zino-hofmann/graphql-flutter/commit/e59d40693125c8502d7fd7dcdb4817ece4645052)). @vincenzopalazzo 22-07-2022 ## Deprecated - deprecate the `SocketSubProtocol` to improve naming ([commit](https://github.com/zino-hofmann/graphql-flutter/commit/2afd58362b2b107197004a14a61152ec8985fa1f)). @vincenzopalazzo 22-07-2022