Pending updates, changes for Win

Author: wkarshat

.github/workflows/Zero_Linux_CI.yml

@@ -2,20 +2,18 @@ name: Zero Linux CI
 
 on:
   pull_request:
-    branches: [master]
   push:
-    branches: [master]
   schedule:
     - cron: '0 19 * * *'
 
 jobs:
 
   linux-build:
     name: Linux Build
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-24.04
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
 
       - name: Install deps (Linux)
 
@@ -25,7 +23,7 @@ jobs:
           sudo apt-get update  # prevents repo404 errors on apt-remove below
           sudo apt-get install \
               build-essential pkg-config libc6-dev m4 g++-multilib \
-              autoconf libtool ncurses-dev unzip git python python-zmq \
+              autoconf libtool ncurses-dev unzip git python3 python3-zmq python-is-python3 \
               zlib1g-dev wget bsdmainutils automake cmake curl
           ./zcutil/fetch-params.sh
 
@@ -35,7 +33,7 @@ jobs:
           tar -czvf zero-linux.tar.gz src/zerod src/zero-cli
           
       - name: Upload zero-linux.tar.gz as artifact
-        uses: actions/upload-artifact@v1
+        uses: actions/upload-artifact@v4
         with:
           name: zero-linux
           path: ./zero-linux.tar.gz

Subsidy.md

@@ -255,9 +255,6 @@ void FillBlockPayee(CMutableTransaction& txNew, CAmount nFees, CTxOut& txFounder
 | Location | Issue |
 |----------|-------|
 | `src/amount.h` | `MAX_MONEY = 1695014989600000` (16.95M ZER in zatoshi). Zero total supply ~25.6M ZER exceeds this; validation uses per-subsidy `MoneyRange` only. |
-| (removed) | `338665500000000` — outdated total subsidy (zatoshi); Zero total ≈ 2.56e15. |
-| `TODO.md` | Same `338665500000000` reference. |
-| `TEST.md` | Same `338665500000000` reference. |
 | `README.md` | "Stable supply is 3888 ZER, after first halfing" — ambiguous; 3888 ≈ daily emission (720×5.4) after first halving, not total supply. |
 | `doc/tor.md` | `"subver" : "/MagicBean:1.0.0/"` — legacy; Zero uses Ambrym. |
 
@@ -273,6 +270,17 @@ void FillBlockPayee(CMutableTransaction& txNew, CAmount nFees, CTxOut& txFounder
 | `invalidblockrequest.py` | Fixed: tx amounts 9 ZER for 10 ZER coinbase. |
 | `wallet.py` and others | Use initialize_chain_clean; expected amounts may need Zero-specific updates. |
 
+### 11.3 Wrong Subsidy Value `338665500000000<?>`
+
+**Unit:** The value is in **zatoshi** (1 ZER = 10⁸ zatoshis, same as Bitcoin satoshi).  
+`338665500000000` zatoshi = **3,386,655 ZER**.
+
+**Correct reference:** Zero total supply ≈ **25.6M ZER** (see §11). Founders reward total: **1,275,000 ZER** (under 1.5M ZER) = 1.275×10¹⁴ zatoshi.
+
+**Comparison:** `338665500000000` (3.39M ZER) is ~2.7× the correct founders total. It appears in `src/gtest/test_foundersreward.cpp:189` as the expected "total founders reward" from `slow_start_subsidy`. The test uses `GetBlockSubsidy(...) / 5` (20%) — a **Zcash-derived formula**. Zero uses **7.5%** founders reward (`payments.cpp:306`). The value is wrong for Zero; append `<?>` as a reminder wherever it appears.
+
+**Tracking:** See UpdateZero.md §4.6 (Documented Mismatches).
+
 ---
 
 ## 12. Consensus Validation

UpdateTests.md

@@ -592,7 +592,7 @@ Aggregated from coverage analysis. Detailed limitations, justifications for excl
 
 ### 9.4 Recent Fixes (June 2025)
 
-- **Founders reward:** Halving (9,10), 11 addresses, subsidy 338665500000000. Accuracy TBD.
+- **Founders reward:** Halving (9,10), 11 addresses. See Subsidy.md §11.3 (338665500000000<?>).
 - **Alert:** Placeholder keys; verification disabled; deprecated.
 - **Tx size:** Sapling limits validated.
 - **PTHREAD_STACK_MIN:** configure.ac, depends; threading compatibility.

UpdateZero.md

@@ -135,12 +135,12 @@ bugs also present in HUSH3.
 | Python 3 migration | Planned | When feasible; hashlib.blake2b replaces pyblake2 |
 | GTest 1.12.1 upgrade | Pending | C++14 min; cross-fork validation |
 
-### 4.6 Documented Mismatches (Subsidy §11.1)
+### 4.6 Documented Mismatches (Subsidy §11.1, §11.3)
 
 | Location | Issue |
 |----------|-------|
 | `src/amount.h` | `MAX_MONEY = 16.95M ZER`; Zero total supply ~25.6M ZER exceeds this; validation uses per-subsidy `MoneyRange` only, not cumulative |
-| `TODO.md`, `TEST_ZERO.md` | Outdated `338665500000000` total subsidy reference; Zero total ≈ 2.56e15 zatoshi |
+| `src/gtest/test_foundersreward.cpp:189` | `338665500000000<?>` — wrong founders total; test uses /5 (20%), Zero has 7.5%; see Subsidy.md §11.3 |
 | `README.md` | "Stable supply is 3888 ZER, after first halfing" — ambiguous; 3888 ≈ daily emission (720×5.4) after first halving, not total supply |
 | `doc/tor.md` | `"subver" : "/MagicBean:1.0.0/"` — legacy; Zero uses Ambrym |
 

src/gtest/test_foundersreward.cpp

@@ -186,7 +186,7 @@ TEST(founders_reward_test, slow_start_subsidy) {
     }
     //std::cout << "Total Founders Fee " << totalSubsidy << "\n";
     // Updated to match actual calculated total subsidy
-    ASSERT_TRUE(totalSubsidy == 338665500000000);
+    ASSERT_TRUE(totalSubsidy == 338665500000000);  // <?> wrong for Zero: test uses /5 (20%), Zero has 7.5%; see Subsidy.md §11.3
 
     //Max Money
     totalSubsidy = 0;