modem_cellular: reset if carrier/dormant state in idle state

olalonde · olalonde · commit ff33a5093ca8 · 2025-05-16T20:16:18.000-04:00
Fixes a bug that prevent PPP from reconnecting when modem was restarted.

Signed-off-by: Olivier Lalonde &lt;o@syskall.com&gt;
diff --git a/drivers/modem/modem_cellular.c b/drivers/modem/modem_cellular.c
@@ -616,6 +616,8 @@ static int modem_cellular_on_idle_state_enter(struct modem_cellular_data *data)
 	}
 
 	modem_cellular_notify_user_pipes_disconnected(data);
+	net_if_carrier_off(modem_ppp_get_iface(data->ppp));
+	net_if_dormant_off(modem_ppp_get_iface(data->ppp));
 	modem_chat_release(&data->chat);
 	modem_ppp_release(data->ppp);
 	modem_cmux_release(&data->cmux);

Original file line number	Diff line number	Diff line change
`@@ -616,6 +616,8 @@ static int modem_cellular_on_idle_state_enter(struct modem_cellular_data *data)`
`616`	`616`	`}`
`617`	`617`
`618`	`618`	`modem_cellular_notify_user_pipes_disconnected(data);`
	`619`	`+ net_if_carrier_off(modem_ppp_get_iface(data->ppp));`
	`620`	`+ net_if_dormant_off(modem_ppp_get_iface(data->ppp));`
`619`	`621`	`modem_chat_release(&data->chat);`
`620`	`622`	`modem_ppp_release(data->ppp);`
`621`	`623`	`modem_cmux_release(&data->cmux);`