drivers: sensor: bmm350: add default odr/osr

Add a way to define the default odr and osr with devicetree for
the bmm350.

Signed-off-by: Ryan McClelland <[email protected]>

Author: XenuIsWatching

drivers/sensor/bosch/bmm350/bmm350.c

@@ -710,7 +710,7 @@ static uint8_t mag_odr_to_reg(const struct sensor_value *val)
 static uint8_t mag_osr_to_reg(const struct sensor_value *val)
 {
 	switch (val->val1) {
-	case 0:
+	case 1:
 		return BMM350_NO_AVERAGING;
 	case 2:
 		return BMM350_AVERAGING_2;
@@ -1053,9 +1053,12 @@ static int pm_action(const struct device *dev, enum pm_device_action action)
 static int bmm350_init(const struct device *dev)
 {
 	int err = 0;
+	const struct bmm350_config *config = dev->config;
 	struct bmm350_data *data = dev->data;
-	const struct sensor_value odr = {100, 0};
-	const struct sensor_value osr = {2, 0};
+	const struct sensor_value osr = {config->default_osr, 0};
+	struct sensor_value odr;
+
+	mag_reg_to_odr(config->default_odr, &odr);
 
 	err = bmm350_bus_check(dev);
 	if (err < 0) {
@@ -1078,8 +1081,9 @@ static int bmm350_init(const struct device *dev)
 	/* Assign axis_en with all axis enabled (BMM350_EN_XYZ_MSK) */
 	data->axis_en = BMM350_EN_XYZ_MSK;
 
-	/* Initialize to 100Hz, averaging between 2 samples by default */
+	/* Initialize to odr and osr */
 	if (set_mag_odr_osr(dev, &odr, &osr) < 0) {
+		LOG_ERR("failed to set default odr and osr");
 		return -EIO;
 	}
 
@@ -1095,6 +1099,8 @@ static int bmm350_init(const struct device *dev)
 	static const struct bmm350_config bmm350_config_##inst = {                                 \
 		.bus.i2c = I2C_DT_SPEC_INST_GET(inst),                                             \
 		.bus_io = &bmm350_bus_io_i2c,                                                      \
+		.default_odr = DT_INST_ENUM_IDX(inst, odr) + BMM350_DATA_RATE_400HZ,               \
+		.default_osr = DT_INST_PROP(inst, osr),                                            \
 		BMM350_INT_CFG(inst)};                                                             \
                                                                                                    \
 	PM_DEVICE_DT_INST_DEFINE(inst, pm_action);                                                 \

drivers/sensor/bosch/bmm350/bmm350.h

@@ -452,6 +452,8 @@ struct bmm350_config {
 	struct bmm350_bus bus;
 	const struct bmm350_bus_io *bus_io;
 	struct gpio_dt_spec drdy_int;
+	uint8_t default_odr;
+	uint8_t default_osr;
 };
 
 struct bmm350_data {

dts/bindings/sensor/bosch,bmm350.yaml

@@ -10,3 +10,43 @@ properties:
     description: |
       This property specifies the connection for data ready pin.
       The polarity default is active high when sensor data is ready.
+
+  odr:
+    type: string
+    description: |
+      Default output data rate in Hz. Only the following values are allowed:
+        400    - 400     - 2.5ms
+        200    - 200     - 5ms
+        100    - 100     - 10ms
+        50     - 50      - 20ms
+        25     - 25      - 40ms
+        12.5   - 25/2    - 80ms
+        6.25   - 25/4    - 160ms
+        3.125  - 25/8    - 320ms
+        1.5625 - 25/16   - 640ms
+    default: "100"
+    enum:
+      - "400"
+      - "200"
+      - "100"
+      - "50"
+      - "25"
+      - "12.5"
+      - "6.25"
+      - "3.125"
+      - "1.5625"
+
+  osr:
+    type: int
+    description: |
+      Default oversampling. Only the following values are allowed:
+        8 - 8x
+        4 - 4x
+        2 - 2x
+        1 - 1x
+    default: 2
+    enum:
+      - 1
+      - 2
+      - 4
+      - 8