Skip to content

Commit a55a967

Browse files
kartbenfabiobaltieri
authored andcommitted
drivers: gpio: max149xx: fix error handling
Use signed variable for negative error codes so that potential errors are actually detected and returned properly. Signed-off-by: Benjamin Cabé <[email protected]>
1 parent e8caaf4 commit a55a967

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

drivers/gpio/gpio_max14906.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ static int max14906_reg_trans_spi_diag(const struct device *dev, uint8_t addr, u
8282
LOG_ERR("[FAULT] pin triggered");
8383
}
8484

85-
uint8_t ret = max149x6_reg_transceive(dev, addr, tx, rx_diag_buff, rw);
85+
int ret = max149x6_reg_transceive(dev, addr, tx, rx_diag_buff, rw);
8686

8787
if (max14906_pars_spi_diag(dev, rx_diag_buff, rw)) {
8888
ret = -EIO;

drivers/gpio/gpio_max14916.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ static int max14916_reg_trans_spi_diag(const struct device *dev, uint8_t addr, u
8585
LOG_ERR(" >>> FLT PIN");
8686
}
8787

88-
uint8_t ret = max149x6_reg_transceive(dev, addr, tx, rx_diag_buff, rw);
88+
int ret = max149x6_reg_transceive(dev, addr, tx, rx_diag_buff, rw);
8989

9090
if (max14916_pars_spi_diag(dev, rx_diag_buff, rw)) {
9191
ret = -EIO;

0 commit comments

Comments
 (0)