platform: Make sure picolibc.c is included in every build when needed

Add picolibc.c to many source lists when CONFIG_PICOLIBC is defined to
ensure the constructor is defined. If this file is missing, linking
with picolibc will fail because this file also defines some symbols
needed by picolibc's crt0.o

Signed-off-by: Keith Packard <[email protected]>

Author: keith-packard

bl1/bl1_1/CMakeLists.txt

@@ -40,6 +40,7 @@ target_link_options(bl1_1
 target_sources(bl1_1
     PRIVATE
         main.c
+        $<$<BOOL:${CONFIG_PICOLIBC}>:${CMAKE_SOURCE_DIR}/platform/ext/common/picolibc.c>
         $<$<BOOL:${CONFIG_GNU_SYSCALL_STUB_ENABLED}>:${CMAKE_SOURCE_DIR}/platform/ext/common/syscalls_stub.c>
 )
 

bl1/bl1_2/CMakeLists.txt

@@ -42,6 +42,7 @@ target_link_options(bl1_2
 target_sources(bl1_2
     PRIVATE
         main.c
+        $<$<BOOL:${CONFIG_PICOLIBC}>:${CMAKE_SOURCE_DIR}/platform/ext/common/picolibc.c>
         $<$<BOOL:${CONFIG_GNU_SYSCALL_STUB_ENABLED}>:${CMAKE_SOURCE_DIR}/platform/ext/common/syscalls_stub.c>
 )
 

bl2/CMakeLists.txt

@@ -128,6 +128,7 @@ add_executable(bl2
     $<$<BOOL:${DEFAULT_MCUBOOT_FLASH_MAP}>:src/default_flash_map.c>
     $<$<BOOL:${MCUBOOT_DATA_SHARING}>:src/shared_data.c>
     $<$<BOOL:${PLATFORM_DEFAULT_PROVISIONING}>:src/provisioning.c>
+    $<$<BOOL:${CONFIG_PICOLIBC}>:${CMAKE_SOURCE_DIR}/platform/ext/common/picolibc.c>
     $<$<BOOL:${CONFIG_GNU_SYSCALL_STUB_ENABLED}>:${CMAKE_SOURCE_DIR}/platform/ext/common/syscalls_stub.c>
 )
 

cmake/install.cmake

@@ -254,6 +254,11 @@ install(DIRECTORY   $<BUILD_INTERFACE:${CMSIS_PATH}/CMSIS/Core/Include>
                     $<BUILD_INTERFACE:${CMSIS_PATH}/CMSIS/Driver/Include>
         DESTINATION ${INSTALL_PLATFORM_NS_DIR}/ext/cmsis)
 
+if(CONFIG_PICOLIBC)
+    install(FILES       ${PLATFORM_DIR}/ext/common/picolibc.c
+            DESTINATION ${INSTALL_PLATFORM_NS_DIR}/ext/common)
+endif()
+
 if(PLATFORM_DEFAULT_UART_STDOUT)
     install(FILES       ${PLATFORM_DIR}/ext/common/uart_stdout.c
                         ${PLATFORM_DIR}/ext/common/uart_stdout.h

cmake/spe-CMakeLists.cmake

@@ -104,6 +104,7 @@ add_subdirectory(platform)
 
 target_sources(platform_ns
     PRIVATE
+        $<$<BOOL:${CONFIG_PICOLIBC}>:${CMAKE_CURRENT_SOURCE_DIR}/platform/ext/common/picolibc.c>
         $<$<BOOL:${PLATFORM_DEFAULT_UART_STDOUT}>:${CMAKE_CURRENT_SOURCE_DIR}/platform/ext/common/uart_stdout.c>
 )
 

platform/CMakeLists.txt

@@ -81,6 +81,7 @@ target_sources(platform_s
         $<$<BOOL:${PLATFORM_DEFAULT_PROVISIONING}>:ext/common/provisioning.c>
         $<$<OR:$<BOOL:${TEST_S_FPU}>,$<BOOL:${TEST_NS_FPU}>>:${CMAKE_SOURCE_DIR}/platform/ext/common/test_interrupt.c>
         $<$<BOOL:${TFM_SANITIZE}>:ext/common/tfm_sanitize_handlers.c>
+        $<$<BOOL:${CONFIG_PICOLIBC}>:ext/common/picolibc.c>
         ./ext/common/tfm_fatal_error.c
 )
 
@@ -90,7 +91,6 @@ target_sources(platform_s
 target_sources(tfm_s
     PRIVATE
         ext/common/faults.c
-        ext/common/picolibc.c
 )
 
 target_link_libraries(platform_s
@@ -204,6 +204,7 @@ if(BL2)
             $<$<OR:$<BOOL:${PLATFORM_DEFAULT_NV_COUNTERS}>,$<BOOL:${PLATFORM_DEFAULT_OTP}>>:ext/common/template/flash_otp_nv_counters_backend.c>
             $<$<BOOL:${PLATFORM_DEFAULT_OTP}>:ext/common/template/otp_flash.c>
             $<$<BOOL:${BL2_SANITIZE}>:ext/common/tfm_sanitize_handlers.c>
+            $<$<BOOL:${CONFIG_PICOLIBC}>:ext/common/picolibc.c>
             ./ext/common/tfm_fatal_error.c
     )
 
@@ -305,6 +306,7 @@ if(BL1 AND PLATFORM_DEFAULT_BL1)
             $<$<BOOL:${PLATFORM_DEFAULT_OTP}>:ext/common/template/flash_otp_nv_counters_backend.c>
             $<$<BOOL:${PLATFORM_DEFAULT_OTP}>:ext/common/template/otp_flash.c>
             $<$<OR:$<BOOL:${BL1_1_SANITIZE}>,$<BOOL:${TFM_BL1_2_SANITIZE}>>:ext/common/tfm_sanitize_handlers.c>
+            $<$<BOOL:${CONFIG_PICOLIBC}>:ext/common/picolibc.c>
             ./ext/common/tfm_fatal_error.c
     )
 
@@ -360,6 +362,7 @@ if(BL1 AND PLATFORM_DEFAULT_BL1)
             $<$<BOOL:${PLATFORM_DEFAULT_NV_COUNTERS}>:ext/common/template/nv_counters.c>
             $<$<OR:$<BOOL:${PLATFORM_DEFAULT_NV_COUNTERS}>,$<BOOL:${PLATFORM_DEFAULT_OTP}>>:ext/common/template/flash_otp_nv_counters_backend.c>
             $<$<BOOL:${PLATFORM_DEFAULT_OTP}>:ext/common/template/otp_flash.c>
+            $<$<BOOL:${CONFIG_PICOLIBC}>:ext/common/picolibc.c>
     )
 
     target_link_libraries(platform_bl1_2

platform/ext/common/provisioning_bundle/CMakeLists.txt

@@ -54,6 +54,7 @@ target_sources(provisioning_bundle
     PRIVATE
         ./provisioning_code.c
         ./provisioning_data.c
+        $<$<BOOL:${CONFIG_PICOLIBC}>:${CMAKE_SOURCE_DIR}/platform/ext/common/picolibc.c>
         $<$<BOOL:${CONFIG_GNU_SYSCALL_STUB_ENABLED}>:${CMAKE_SOURCE_DIR}/platform/ext/common/syscalls_stub.c>
 )
 

platform/ext/target/arm/mps4/common/provisioning/bundle_cm/CMakeLists.txt

@@ -62,6 +62,7 @@ target_sources(cm_provisioning_bundle
     PRIVATE
         cm_provisioning_code.c
         cm_provisioning_data.c
+        $<$<BOOL:${CONFIG_PICOLIBC}>:${CMAKE_SOURCE_DIR}/platform/ext/common/picolibc.c>
         $<$<BOOL:${CONFIG_GNU_SYSCALL_STUB_ENABLED}>:${CMAKE_SOURCE_DIR}/platform/ext/common/syscalls_stub.c>
 )
 

platform/ext/target/arm/mps4/common/provisioning/bundle_dm/CMakeLists.txt

@@ -65,6 +65,7 @@ target_sources(dm_provisioning_bundle
     PRIVATE
         dm_provisioning_code.c
         dm_provisioning_data.c
+        $<$<BOOL:${CONFIG_PICOLIBC}>:${CMAKE_SOURCE_DIR}/platform/ext/common/picolibc.c>
         $<$<BOOL:${CONFIG_GNU_SYSCALL_STUB_ENABLED}>:${CMAKE_SOURCE_DIR}/platform/ext/common/syscalls_stub.c>
 )
 

platform/ext/target/arm/rse/common/provisioning/bundle/CMakeLists.txt

@@ -67,6 +67,7 @@ macro(create_provisioning_code_target target)
 
     target_sources(${target}_provisioning_code
         PRIVATE
+            $<$<BOOL:${CONFIG_PICOLIBC}>:${CMAKE_SOURCE_DIR}/platform/ext/common/picolibc.c>
             $<$<BOOL:${CONFIG_GNU_SYSCALL_STUB_ENABLED}>:${CMAKE_SOURCE_DIR}/platform/ext/common/syscalls_stub.c>
     )