2.x checklist

[kbond]

(to be moved to 2.x PR)

• remove deprecated code
• migrate remaining features from foundry-next
• deprecate Zenstruck\Foundry\anonymous() in favor of Zenstruck\Foundry\factory()
• split packages? (foundry-persistence, foundry-orm, foundry-mongo)
• remove requirement/need for zenstruck/callback
• Attributes can be a callable that accepts an int (marking the current # being created when creating a collection)

[nikophil]

• inverse_one_to_many_relationship_without_cascade() feat: an array could be passed for a OneToMany relation kbond/foundry-next#12
• fixed by feat: handle when an entity have two relationships to the same entity kbond/foundry-next#17
  • one_to_many_with_two_relationships_same_entity()
  • one_to_many_with_two_relationships_same_entity_and_adders()
  • can_use_adder_as_attributes()
  • inverse_many_to_many_with_two_relationships_same_entity()
  • one_to_many_polymorphic_with_nested_collection_relationship()
• ModelFactoryTest::can_set_state_via_new => refactor(bc layer): deprecate passing states as string to Factory::new() #559
• fixed by fix: allow to get proxy's real object if it is modified kbond/foundry-next#22
  • ODMModelFactoryTest::can_use_adder_as_attributes
  • ODMModelFactoryTest::can_find_or_create_from_proxy_of_object
  • ODMModelFactoryTest::can_hydrate_embed_many_fields
  • ODMModelFactoryTest::can_use_factory_for_embedded_object

Static analysis

• I think we have a complex SCA problem:

// SomeObjectFactory extends PersistentProxyObjectFactory
return $this->instantiateWith(
    static fn () => new SomeObject()
)

this code results in this error (I've replaced the full object FQCN by T for better readability)

Parameter #1 $instantiator of method Zenstruck\Foundry\ObjectFactory<T&Zenstruck\Foundry\Persistence\Proxy>::instantiateWith()
expects (callable(array<string, mixed>, class-string<T&Zenstruck\Foundry\Persistence\Proxy>): (T&Zenstruck\Foundry\Persistence\Proxy))|Zenstruck\Foundry\Object\Instantiator,
Closure(): T given.

=> phpstan wants a closure which returns a T&Proxy<T> because the factory is a "persistence with proxy", and the template type is T&Proxy<T>. I think this is a blocker

[nikophil]

I'm adding some todo here
both of these PRs should be ported in 2.x:

• fix: restore error handler in Foundry's traits #577 (fix(2.x): restore PHPUnit error handler #587)
• [1.x] fix using stories with simple objects #580
• Configure default_namespace for make_story #592 => feat(2.x): allow to configure default namespace fo make:factory #600