fix: do not considering NoAction bindings to be pending

joe-p · joe-p · commit ede008a65cab · 2025-05-08T16:34:25.000-04:00
diff --git a/crates/gpui/src/keymap.rs b/crates/gpui/src/keymap.rs
@@ -153,7 +153,7 @@ impl Keymap {
             for depth in (0..=context_stack.len()).rev() {
                 if self.binding_enabled(binding, &context_stack[0..depth]) {
                     if is_pending.is_none() {
-                        is_pending = Some(pending);
+                        is_pending = Some(pending && !is_no_action(&*binding.action))
                     }
                     if !pending {
                         bindings.push((binding.clone(), depth));

Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,7 @@ impl Keymap {`
`153`	`153`	`for depth in (0..=context_stack.len()).rev() {`
`154`	`154`	`if self.binding_enabled(binding, &context_stack[0..depth]) {`
`155`	`155`	`if is_pending.is_none() {`
`156`		`- is_pending = Some(pending);`
	`156`	`+ is_pending = Some(pending && !is_no_action(&*binding.action))`
`157`	`157`	`}`
`158`	`158`	`if !pending {`
`159`	`159`	`bindings.push((binding.clone(), depth));`