Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve expander module handling during startup #115

Open
8 of 14 tasks
JensOgorek opened this issue Dec 11, 2024 · 0 comments · May be fixed by #117 or #118
Open
8 of 14 tasks

Improve expander module handling during startup #115

JensOgorek opened this issue Dec 11, 2024 · 0 comments · May be fixed by #117 or #118
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@JensOgorek
Copy link
Contributor

JensOgorek commented Dec 11, 2024

After #111 & #114 we decided to change the way expander are handled in startups.

What is to change:

  • after initiating an expander module, stop the normal execution of the startup script or the console with a while loop, until the expander is ready or a timeout is surpassed.
  • execute the startup script "normally" (most expander/proxy functionality won't be set up correctly)
  • make it possible to flash an expander esp in the error state
  • let the error state be broadcasted → core.has_error can be subscribed with broadcast

Error handling, example implementation for expander module:

  • error code functionality
  • set errors
  • have an error status readable → core.has_error is a bool property, that can be subscribed with broadcast
  • have a way to receive all errors → core.get_errors()

Ideas for future additions:

  • if a proxy is created while the expander module is not ready, there should be an error
  • don't let critical functions execute when in the error state
  • Handle different error states → ideas: No Error, Connection Timeout, Connection Failed
  • Notify the user about the error state → other than broadcast, maybe when using Lizard
  • important modules have their own error states → Core, Expander?
  • when meeting the initial timeout, try to reboot the expander esp until it is finally in an error state
@JensOgorek JensOgorek added the enhancement New feature or request label Dec 11, 2024
@JensOgorek JensOgorek added this to the 0.7.0 milestone Dec 11, 2024
@rodja rodja changed the title Startup-script rehaul Improve expander module handling during startup Dec 12, 2024
@JensOgorek JensOgorek linked a pull request Dec 12, 2024 that will close this issue
@JensOgorek JensOgorek linked a pull request Dec 13, 2024 that will close this issue
@JensOgorek JensOgorek self-assigned this Dec 13, 2024
@JensOgorek JensOgorek linked a pull request Dec 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant