Use context manager for temp dirs in store tests (#3110)

Co-authored-by: Davis Bennett <[email protected]>

Author: maxrjones

tests/test_store/test_core.py

@@ -18,6 +18,26 @@
 )
 
 
+@pytest.fixture(
+    params=["none", "temp_dir_str", "temp_dir_path", "store_path", "memory_store", "dict"]
+)
+def store_like(request):
+    if request.param == "none":
+        yield None
+    elif request.param == "temp_dir_str":
+        with tempfile.TemporaryDirectory() as temp_dir:
+            yield temp_dir
+    elif request.param == "temp_dir_path":
+        with tempfile.TemporaryDirectory() as temp_dir:
+            yield Path(temp_dir)
+    elif request.param == "store_path":
+        yield StorePath(store=MemoryStore(store_dict={}), path="/")
+    elif request.param == "memory_store":
+        yield MemoryStore(store_dict={})
+    elif request.param == "dict":
+        yield {}
+
+
 @pytest.mark.parametrize("path", ["foo", "foo/bar"])
 @pytest.mark.parametrize("write_group", [True, False])
 @pytest.mark.parametrize("zarr_format", [2, 3])
@@ -134,17 +154,6 @@ async def test_make_store_path_fsspec(monkeypatch) -> None:
     assert isinstance(store_path.store, FsspecStore)
 
 
-@pytest.mark.parametrize(
-    "store_like",
-    [
-        None,
-        tempfile.TemporaryDirectory().name,
-        Path(tempfile.TemporaryDirectory().name),
-        StorePath(store=MemoryStore(store_dict={}), path="/"),
-        MemoryStore(store_dict={}),
-        {},
-    ],
-)
 async def test_make_store_path_storage_options_raises(store_like: StoreLike) -> None:
     with pytest.raises(TypeError, match="storage_options"):
         await make_store_path(store_like, storage_options={"foo": "bar"})