fix: add destructure duplicated props (#196)

Author: Ilanaya

typescript/src/codeActions/custom/addDestructure/addSplittedDestructure.ts

@@ -1,3 +1,4 @@
+import { uniq } from 'rambda'
 import { findChildContainingExactPosition, getChangesTracker, getPositionHighlights, isValidInitializerForDestructure, makeUniqueName } from '../../../utils'
 
 export default (node: ts.Node, sourceFile: ts.SourceFile, formatOptions: ts.FormatCodeSettings | undefined, languageService: ts.LanguageService) => {
@@ -56,7 +57,7 @@ export default (node: ts.Node, sourceFile: ts.SourceFile, formatOptions: ts.Form
 
     if (!nodeToReplaceWithBindingPattern || propertyNames.length === 0) return
 
-    const bindings = propertyNames.map(({ initial, unique }) => {
+    const bindings = uniq(propertyNames).map(({ initial, unique }) => {
         return ts.factory.createBindingElement(undefined, unique ? initial : undefined, unique ?? initial)
     })
 

typescript/test/codeActions/addDestruct.spec.ts

@@ -26,6 +26,37 @@ describe('Add destructure', () => {
 
             const { codeAction } = fourslashLikeTester(initial, undefined, { dedent: true })
 
+            codeAction(0, {
+                refactorName: 'Add Destruct',
+                newContent: expected,
+            })
+        })
+        test('Multiple same prop extractions', () => {
+            const initial = /* ts */ `
+              const /*t*/props/*t*/ = {
+                source: {
+                  type: Object,
+                  required: true,
+                },
+              };
+              const test = props.source;
+              const test2 = props.source;
+              const test3 = props.source;
+            `
+            const expected = /* ts */ `
+              const { source } = {
+                source: {
+                  type: Object,
+                  required: true,
+                },
+              };
+              const test = source;
+              const test2 = source;
+              const test3 = source;
+            `
+
+            const { codeAction } = fourslashLikeTester(initial, undefined, { dedent: true })
+
             codeAction(0, {
                 refactorName: 'Add Destruct',
                 newContent: expected,

typescript/test/codeActions/fromDestruct.spec.ts

@@ -52,10 +52,10 @@ describe('From destructure', () => {
             )
 
             expect(content).toMatchInlineSnapshot(`
-        "
-            const something: number = anObject.something;
-        "
-      `)
+              "
+                  const something: number = anObject.something;
+              "
+            `)
         })
     })
     test('Should convert nested', () => {
@@ -204,12 +204,12 @@ describe('From destructure', () => {
                 { compareContent: true },
             )
             expect(newContent).toMatchInlineSnapshot(`
-            "
-                const foo = {
-                foo: 1,
-            }.foo
-            "
-          `)
+              "
+                  const foo = {
+                  foo: 1,
+              }.foo
+              "
+            `)
         })
         test('Destructured two or more properties', () => {
             const initial = /* ts*/ `