fix: light blocks are rendered as unknown blocks #251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
Addressed by 382a685 |
Yes sorry should have pushed there, totally forgot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
This fixes that light blocks would show up as unknown blocks with a question mark texture when they should be invisible
The bug:
After the fix:
PR Type
Bug fix
Description
Fixed rendering issue where light blocks appeared as unknown blocks.
Added
lightto the set of invisible blocks in the mesher constants.Changes walkthrough 📝
worldConstants.ts
Add light blocks to invisible blocks setprismarine-viewer/viewer/lib/mesher/worldConstants.ts
lightto theINVISIBLE_BLOCKSset.