validation: run skipper in validation mode inside webhook #3672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MustafaSaber
added
the
major
MustafaSaber
force-pushed
the
use-skipper-in-validation-mode
branch
3 times, most recently
from
048717e to
eb8cbb6
Compare
|
Even if tests would all pass this will break current installed webhooks if they would update to this version. |
hmm, why? Default port is the same |
MustafaSaber
force-pushed
the
use-skipper-in-validation-mode
branch
from
eb8cbb6 to
e096a8c
Compare
We leave webhook binary for backward combitability but use skipper in validation mode everywhere as source of truth Signed-off-by: Mustafa Abdelrahman <[email protected]>
MustafaSaber
force-pushed
the
use-skipper-in-validation-mode
branch
from
e096a8c to
fc98f7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We leave webhook binary for backward combitability but use skipper in validation mode everywhere as source of truth